Fix missing do_disconnect check in link_inventory #16726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @blomquisg |
agrare
force-pushed
the
fix_missing_disconnect_check_link_inventory
branch
2 times, most recently
from
e9d4ea2 to
65e4a1e
Compare
|
Please note this also fixes: There is a spec for this here: and I think we need it in gaprindashvili |
agrare
force-pushed
the
fix_missing_disconnect_check_link_inventory
branch
from
65e4a1e to
a0e482e
Compare
Fixes an issue found by ManageIQ#16718 where relationships are deleted even though disconnect is false.
agrare
force-pushed
the
fix_missing_disconnect_check_link_inventory
branch
from
a0e482e to
6e27afc
Compare
|
Checked commit agrare@6e27afc with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
…nk_inventory Fix missing do_disconnect check in link_inventory (cherry picked from commit 20b7f84)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue found by #16718
where relationships are deleted even though disconnect is false.
This should fix the failing manageiq-providers-vmware spec test:
https://travis-ci.org/ManageIQ/manageiq-providers-vmware/jobs/323975743#L2282-L2292