Disconnect inventory on targeted refresh #16718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
while not directly fixing it, this is required to fix: https://bugzilla.redhat.com/show_bug.cgi?id=1511445 |
borod108
force-pushed
the
bugs/disconnect_ems_template
branch
from
07459d0 to
7f66cf9
Compare
When doing a targeted refresh the condition to disconnect the target from the ems was not granular enough. For example in some cases when refreshing a template the 'folder' hashes were not not empty while the 'template' hashes were, still the template was not disconnected from the ems in that case. The new condition is more accurate and should mitigate this kind of scenarios. This is part of prs that fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1511445
borod108
force-pushed
the
bugs/disconnect_ems_template
branch
from
7f66cf9 to
5eb95a4
Compare
|
Checked commit borod108@5eb95a4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
pkliczewski
approved these changes
Jan 2, 2018
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Jan 2, 2018
Fixes an issue found by ManageIQ#16718 where relationships are deleted even though disconnect is false.
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Jan 2, 2018
Fixes an issue found by ManageIQ#16718 where relationships are deleted even though disconnect is false.
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Jan 2, 2018
Fixes an issue found by ManageIQ#16718 where relationships are deleted even though disconnect is false.
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Jan 3, 2018
Fixes an issue found by ManageIQ#16718 where relationships are deleted even though disconnect is false.
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
Disconnect inventory on targeted refresh (cherry picked from commit 14d1aa3)
|
Gaprindashvili backport details: |
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Jan 3, 2018
Fixes an issue found by ManageIQ#16718 where relationships are deleted even though disconnect is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a targeted refresh the condition to disconnect the target
from the ems was not granular enough.
For example in some cases when refreshing a template the 'folder' hashes
were not not empty while the 'template' hashes were, still the template
was not disconnected from the ems in that case.
The new condition is more accurate and should mitigate this kind of
scenarios.
The specs for this PR are here: ManageIQ/manageiq-providers-ovirt#184