Introduce $vcloud_log that logs into log/vcloud.log

[miha-plesko]

With this commit we introduce yet another global logger that is to be used by VMware provider. We're having quite some logs there and it's better to log them into its own file.

@miq-bot add_label enhancement
@miq-bot assign @Fryguy

Related issue: #16642
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1525201

/cc @blomquisg @gberginc

[gberginc]

LGTM

Reassigning to @blomquisg because he's been involved in the discussions.
@miq-bot assign @blomquisg

@miha-plesko Please, open an issue and mention that that's a request from Red Hat support team.

Adding labels for backports.
@miq-bot add_label gaprindashvili/yes, fine/yes

@chargio Please check that this is correct.

[chargio]

@blomquisg @agrare We need some guidelines here:

• What should be the name of the log. Should it be independent on other VMware providers?
• What information is in this log and what should be in production.log?

[agrare]

I think this should be called vcloud.log, we already have vim.log for vSphere (VIM is the name of the sdk) so vmware.log would be misleading. This also follows the pattern of other providers e.g. aws.log and azure.log

[miha-plesko]

I like vcloud better too, because we're not going to be using it for infra manager anyway. Thanks for noticing, I've repushed.

[miq-bot]

Checked commit miha-plesko@cb112a8 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[agrare]

LGTM

[agrare]

I'm going to remove the backport labels since this is an RFE and doesn't seem to be critical

[miha-plesko]

@agrare thanks for merging. Could you also take a look at #16455? Exactly same thing, only for Nuage provider.

[agrare]

@miha-plesko no problem :)
There is an open question to Jason on that one that hasn't been resolved

[chargio]

@agrare The request for this comes from Support. They need the logs to be able to support properly the provider.

So I would add the labels back if you don't mind 😄 , we want them backported

[blomquisg]

Adding back the backport labels. This is specific for a Fine release.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit e37bb361a6b2a174ec46d42ab58686e655395203
Author: Adam Grare <[email protected]>
Date:   Wed Dec 13 12:18:09 2017 -0500

    Merge pull request #16641 from miha-plesko/vcd-logger
    
    Introduce $vcloud_log that logs into log/vcloud.log
    (cherry picked from commit d14404370304efc0e5b1243a750e2c8da03ed4e4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1527555

[simaishi]

@miha-plesko Please create a separate PR for Fine branch. The logging has changed in master in #15397 and there are conflicts backporting this to Fine branch.

[miha-plesko]

Done, I've assigned you on the fine PR. Probably we will also want to backport this vmware PR to actually make use of the new $vcloud_log.

[simaishi]

Backported to Fine via #16746