Route VMware vCD logs into its own file #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR relies on a PR from core, hence the WIP label. I've only re-routed logs for cloud- and network- manager, leaving the infra- intact. |
miha-plesko
force-pushed
the
own-logger
branch
2 times, most recently
from
4430cfa to
bc98893
Compare
miha-plesko
changed the title
With this commit we prevent a mess in evm.log which is caused by vmware cloud/network provider's logs. We start using the $vcloud_log logger for the latter. Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
own-logger
branch
from
bc98893 to
4d5f5de
Compare
|
Checked commit miha-plesko@4d5f5de with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
@agrare this is a followup for ManageIQ/manageiq#16641. I kindly ask for a review. Rubocop seems to explode after modifying |
|
Yeah rubocop yells about that a lot and I'm not sure why yet. I don't think it is anything that you're doing. |
agrare
approved these changes
Dec 14, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 19, 2017
Route VMware vCD logs into its own file (cherry picked from commit d5f4df8) https://bugzilla.redhat.com/show_bug.cgi?id=1527555
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 10, 2018
Route VMware vCD logs into its own file (cherry picked from commit d5f4df8) https://bugzilla.redhat.com/show_bug.cgi?id=1531156
|
Fine backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
Target template related actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we prevent a mess in evm.log which is caused by vmware cloud/network provider's logs. We start using the $vcloud_log logger for the latter.
@miq-bot add_label enhancement, gaprindashvili/yes, fine/yes
@miq-bot assign @blomquisg
Related issue: ManageIQ/manageiq#16642
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1525201
Depends on: ManageIQ/manageiq#16641 (merged)
/cc @gberginc