Handle deprecated classes in arel #16560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
arel_attribute
branch
3 times, most recently
from
d6912bd to
a17dc23
Compare
Attribute deprecation is based upon aliases and virtual attributes. Ensure both concepts are working correctly together. Bug: The virtual attribute was generating bogus arel, when it should have been deferring to the attribute_alias mechanism built into rails So the new code prioritizes attribute_alias over virtual_attribute https://bugzilla.redhat.com/show_bug.cgi?id=1507047
kbrock
force-pushed
the
arel_attribute
branch
from
a17dc23 to
36f5385
Compare
|
Checked commit kbrock@36f5385 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Nov 30, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 1, 2017
Handle deprecated classes in arel (cherry picked from commit de70ac0) https://bugzilla.redhat.com/show_bug.cgi?id=1519852
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute deprecation is based upon aliases and virtual attributes.
Ensure both concepts are working correctly together.
Bug: The virtual attribute was generating bogus arel, when it should
have been deferring to the attribute_alias mechanism built into rails
So the new code prioritizes attribute_alias over virtual_attribute
https://bugzilla.redhat.com/show_bug.cgi?id=1507047
This is an alternative to #16489
/cc @gtanzillo @imtayadeway