Handle deprecated attributes (aliased) in VirtualArel.arel_attribute method #16489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kbrock Can you review this one? |
|
Checked commit gtanzillo@9b5c580 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
imtayadeway
reviewed
Nov 22, 2017
| def self.connection | ||
| TestClassBase.connection | ||
| end | ||
| deprecate_attribute :old_col1, :col1 |
There was a problem hiding this comment.
Did you consider adding a new, deprecated column to the existing TestClass? Alternatively, you could add a separate context for the test you added below with its own before/after hooks to manage the lifecycle of this fixture, so that it's not setup/torn down for a lot of tests that don't use it
There was a problem hiding this comment.
👍 I think you could just add this to an existing test class
|
@kbrock Can you please review? This one addresses a Gaprindashvili blocker BZ. Thanks! |
|
Closing in favor of #16560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an MiqExpression bug where an error is raised attempting to get the
arel_attributeof an aliased column. In the case of the bug, the column was aliased due to deprecation like this in theHostmodel -deprecate_attribute :address, :hostnameThe change adds an additional check for whether the column is an alias before attempting to look it up the field in the
_virtual_arelhash which would result in nil. It instead falls into the else and calls super on it where it will get the name of the column it was aliased to.https://bugzilla.redhat.com/show_bug.cgi?id=1507047