Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Middleware Server EAP/Wildfly translation #16492

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Add Middleware Server EAP/Wildfly translation #16492

merged 1 commit into from
Nov 23, 2017

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 17, 2017 •
edited
Loading

Add Translation for Middleware servers so they appear correct in Alert profile listings.

Attempt to do the #16483 correctly.

Fixes: BUG 1511653

Before:
image

After:
image

cc @abonas, @mzazrivec

@miq-bot
Copy link
Member

miq-bot commented Nov 17, 2017

Checked commit tumido@85084c2 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@tumido
Copy link
Member Author

tumido commented Nov 17, 2017

@miq-bot add_label internationalization, providers/middleware, bug

@chessbyte chessbyte self-assigned this Nov 17, 2017
@chessbyte chessbyte requested a review from mzazrivec November 17, 2017 16:01
@abonas
Copy link
Member

abonas commented Nov 19, 2017

@chessbyte merge please?

@mzazrivec mzazrivec mentioned this pull request Nov 20, 2017
Closed
@abonas
Copy link
Member

abonas commented Nov 21, 2017

@miq-bot add_label gaprindashvili/yes

@abonas
Copy link
Member

abonas commented Nov 23, 2017

@mzazrivec @chessbyte @agrare can you merge this please when you are back from holidays

@martinpovolny martinpovolny added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 23, 2017
@martinpovolny martinpovolny merged commit f12857c into ManageIQ:master Nov 23, 2017
simaishi pushed a commit that referenced this pull request Nov 27, 2017
@martinpovolny @simaishi
Merge pull request #16492 from tumido/add_mw_server_translations_new_…
6652c0d 
…attempt

Add Middleware Server EAP/Wildfly translation
(cherry picked from commit f12857c)

https://bugzilla.redhat.com/show_bug.cgi?id=1517952
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 6652c0dfced9aa1f90e35ff0aa80a4f4d3774125
Author: Martin Povolny <[email protected]>
Date:   Thu Nov 23 12:57:13 2017 +0100

    Merge pull request #16492 from tumido/add_mw_server_translations_new_attempt
    
    Add Middleware Server EAP/Wildfly translation
    (cherry picked from commit f12857ccb00d5103783b054e5cbdeeb5b12749ec)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517952

@tumido tumido deleted the add_mw_server_translations_new_attempt branch June 26, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzazrivec mzazrivec mzazrivec approved these changes

Assignees

@martinpovolny martinpovolny

Labels
bug gaprindashvili/backported internationalization providers/middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tumido @miq-bot @abonas @simaishi @mzazrivec @martinpovolny @chessbyte