Add mw server translations #16483

tumido · 2017-11-16T12:24:57Z

Add Translation for Middleware servers so they appear correct in Alert profile listings.

Fixes: BUG 1511653
Depends on (for smaller change set): #16482

Before:

After:

miq-bot · 2017-11-16T12:32:52Z

Checked commits tumido/manageiq@2f3edad~...75fb0b9 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

💣 💥 🔥 🚒 - Linter/Yaml - missing config files

tumido · 2017-11-16T13:30:32Z

@miq-bot add_label internationalization, middleware, bug

miq-bot · 2017-11-16T13:31:33Z

@tumido Cannot apply the following label because they are not recognized: middleware

tumido · 2017-11-16T13:32:17Z

@miq-bot add_label providers/middleware

abonas · 2017-11-16T13:47:34Z

@tumido iiic, this PR contains another commit from a different PR?
@JStickler please review

abonas · 2017-11-16T13:47:54Z

@mzazrivec please review

tumido · 2017-11-16T14:31:39Z

@abonas yes. I can't build this PR upon master if the master is not in sync with itself. So once the dependent PR is merged (which is here as the first commit) the change set would include only the MW related part.

JStickler

Make sure you use the proper spelling and capitalization for Red Hat and VMWare to comply with their corporate branding.
I’m working under the assumption that most of the strings in these files are UI labels for fields and actions and should be consistently capitalized as Title Case (that is, all words capitalized).
It may be that some of the strings that I marked weren’t field or action labels but messages displayed to the user. User messages should be Sentence Case capitalization (capitalize first word only) and you can ignore my attempts to change them to Title Case capitalization.
Also noted instances where I wasn’t sure if I was looking at a parameter or a field label (should this be one word or three?).

JStickler · 2017-11-16T13:59:00Z

config/dictionary_strings.rb

+# TRANSLATORS: en.yml key: dictionary.model.ManageIQ::Providers::Openstack::InfraManager::Host (plural form)
+_("Hosts (OpenStack)")
+# TRANSLATORS: en.yml key: dictionary.model.ManageIQ::Providers::Redhat::InfraManager::Host
+_("Host (Redhat)")


Red Hat is two words, both should be capitalized.

JStickler · 2017-11-16T13:59:25Z

config/dictionary_strings.rb

+# TRANSLATORS: en.yml key: dictionary.model.ManageIQ::Providers::Redhat::InfraManager::Host (plural form)
+_("Hosts (Redhat)")
+# TRANSLATORS: en.yml key: dictionary.model.ManageIQ::Providers::Vmware::InfraManager::Host
+_("Host (Vmware)")


VMware should have the first two letters capitalized.

JStickler · 2017-11-16T14:00:49Z

config/dictionary_strings.rb

+# TRANSLATORS: en.yml key: dictionary.model.ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServerEap (plural form)
+_("Middleware Servers (EAP)")
+# TRANSLATORS: en.yml key: dictionary.model.ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServerWildfly
+_("Middleware Server (Wildfly)")


WildFly should have the "F" capitalized.

JStickler · 2017-11-16T14:03:14Z

config/yaml_strings.rb

 # TRANSLATORS: file: db/fixtures/miq_product_features.yml
-_("Everything under Cloud Object Stores")
+_("Everything under Cloud Object Store Containers")


Should "store" be "storage"? (I'm not sure of the correct terminology here)

JStickler · 2017-11-16T14:09:58Z

config/yaml_strings.rb

@@ -3282,6 +3315,10 @@
 # TRANSLATORS: file: db/fixtures/miq_product_features.yml
 _("Re-check Authentication Status of Physical Infrastructure Providers")
 # TRANSLATORS: file: db/fixtures/miq_product_features.yml
+_("Management Console")
+# TRANSLATORS: file: db/fixtures/miq_product_features.yml
+_("Open a management console")


Open a Management Console
(to be consistent with the title capitalization used elsewhere)

JStickler · 2017-11-16T19:35:23Z

locale/en/manageiq.po

@@ -33368,7 +32319,7 @@ msgstr ""
 msgid "new_flavor_id cannot be nil"
 msgstr ""

-msgid "no %{table} credentials defined"
+msgid "no Provider credentials defined"


No Provider credentials defined

JStickler · 2017-11-16T19:35:42Z

locale/en/manageiq.po

@@ -33389,18 +32340,15 @@ msgstr ""
 msgid "no parent_manager to ems"
 msgstr ""

-msgid "no yml file found for name \"%{name}\""
+msgid "no uid_ems_array defined for linking to service"


No uid_ems_array defined for linking to service

JStickler · 2017-11-16T19:36:09Z

locale/en/manageiq.po

 msgstr ""

-msgid "not connected to ems"
+msgid "no yml file found for name \"%{name}\""


No yml file found for name "%{name}"

JStickler · 2017-11-16T19:36:55Z

locale/en/manageiq.po

 msgid "time_profile must be passed if interval name is 'daily'"
 msgstr ""

-msgid "unable to execute script, file name [%{file_name} does not exist]"
+msgid "unable to execute script, file name [%{file_name}] does not exist"


Unable to execute script....

JStickler · 2017-11-16T21:02:00Z

locale/en/manageiq.po

@@ -7488,7 +7534,22 @@ msgstr ""
 msgid "Data Points"
 msgstr ""

-msgid "Data Store does not exist, unable to add disk"
+msgid "DataSource - Connection Creation Time"


Datasource - Connection Creation Time

(Datasource has been lower case, not camel case, through the rest of these files. Change the next couple of strings to be consistent.)

JStickler

Make sure you use the proper spelling and capitalization for Red Hat and VMWare to comply with their corporate branding.
I’m working under the assumption that most of the strings in these files are UI labels for fields and actions and should be consistently capitalized as Title Case (that is, all words capitalized).
It may be that some of the strings that I marked weren’t field or action labels but messages displayed to the user. User messages should be Sentence Case capitalization (capitalize first word only) and you can ignore my attempts to change them to Title Case capitalization.
Also noted instances where I wasn’t sure if I was looking at a parameter or a field label (should this be one word or three?).

mzazrivec · 2017-11-16T21:45:35Z

That commit updating gettext catalogs should not be included. If you need to add pretty model
names, just edit locale/en.yml and that's it.

Updating gettext catalogs is needed only when you want to upload the strings into Zanata
for translations. And I'm pretty sure that's not what you're doing here.

tumido · 2017-11-17T14:23:11Z

@mzazrivec, @JStickler, I'm gonna close this PR, since @mzazrivec explained it's not needed to do it this way. I got wrong impression from the MIQ i18n docs that I need translations for new strings introduced. So I've tried to put things into order. The wrong way. Let's try it once more and better. Sorry for the clutter. IMO this PR's review by @JStickler should not be wasted and used in strings corrections later.

mzazrivec · 2017-11-17T16:38:52Z

@tumido All you need to do is change locale/en.yml just as you did in this PR. That's all you need
to do really.

abonas · 2017-11-19T10:40:59Z

@tumido why did you close the PR? it seems that you can reopen it, fix the file that @mzazrivec pointed to, take into account @JStickler review and it's good to go

mzazrivec · 2017-11-20T07:21:00Z

@abonas There's #16492 for this.

tumido added 2 commits November 16, 2017 13:09

Update gettext catalogs for master

2f3edad

Add Middleware Server EAP/Wildfly translation

75fb0b9

miq-bot added bug internationalization labels Nov 16, 2017

miq-bot added the providers/middleware label Nov 16, 2017

JStickler reviewed Nov 16, 2017

View reviewed changes

chessbyte requested a review from mzazrivec November 17, 2017 14:20

chessbyte self-assigned this Nov 17, 2017

tumido closed this Nov 17, 2017

tumido mentioned this pull request Nov 17, 2017

Add Middleware Server EAP/Wildfly translation #16492

Merged

tumido deleted the add_mw_server_translations branch June 26, 2018 14:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mw server translations #16483

Add mw server translations #16483

tumido commented Nov 16, 2017

miq-bot commented Nov 16, 2017

tumido commented Nov 16, 2017

miq-bot commented Nov 16, 2017

tumido commented Nov 16, 2017

abonas commented Nov 16, 2017

abonas commented Nov 16, 2017

tumido commented Nov 16, 2017

JStickler left a comment

JStickler Nov 16, 2017

JStickler Nov 16, 2017

JStickler Nov 16, 2017

JStickler Nov 16, 2017

JStickler Nov 16, 2017

JStickler Nov 16, 2017

JStickler Nov 16, 2017

JStickler Nov 16, 2017

JStickler Nov 16, 2017

JStickler Nov 16, 2017

JStickler left a comment

mzazrivec commented Nov 16, 2017

tumido commented Nov 17, 2017

mzazrivec commented Nov 17, 2017

abonas commented Nov 19, 2017

mzazrivec commented Nov 20, 2017

Add mw server translations #16483

Add mw server translations #16483

Conversation

tumido commented Nov 16, 2017

miq-bot commented Nov 16, 2017

tumido commented Nov 16, 2017

miq-bot commented Nov 16, 2017

tumido commented Nov 16, 2017

abonas commented Nov 16, 2017

abonas commented Nov 16, 2017

tumido commented Nov 16, 2017

JStickler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JStickler left a comment

Choose a reason for hiding this comment

mzazrivec commented Nov 16, 2017

tumido commented Nov 17, 2017

mzazrivec commented Nov 17, 2017

abonas commented Nov 19, 2017

mzazrivec commented Nov 20, 2017