Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware compliance assignment #16376

Merged
merged 3 commits into from
Nov 3, 2017
Merged

Middleware compliance assignment #16376

merged 3 commits into from
Nov 3, 2017

Conversation

karelhala
Copy link
Contributor

@karelhala karelhala commented Nov 1, 2017 •
edited
Loading

This PR is follow up of #16375

  • Enables Manage Policies for MW server

Assign policies button which is enabled in toolbar

screenshot from 2017-11-02 14-37-33

Merge after #16375, but before ManageIQ/manageiq-ui-classic#2595

This PR is from set of PRs - ManageIQ/manageiq-ui-classic#2595

@karelhala
Copy link
Contributor Author

@miq-bot add_label enhancement, providers/middleware

@karelhala karelhala mentioned this pull request Nov 1, 2017
Merged
1 task
@karelhala karelhala changed the title Mw compliance assign [WIP] Mw compliance assign Nov 1, 2017
@karelhala
Copy link
Contributor Author

@miq-bot add_label wip

@miq-bot miq-bot added the wip label Nov 1, 2017
@karelhala
Copy link
Contributor Author

@miq-bot remove_label wip

@karelhala karelhala changed the title [WIP] Mw compliance assign Mw compliance assign Nov 2, 2017
@miq-bot miq-bot removed the wip label Nov 2, 2017
@karelhala karelhala closed this Nov 2, 2017
@karelhala karelhala reopened this Nov 2, 2017
@karelhala karelhala closed this Nov 2, 2017
@karelhala karelhala reopened this Nov 2, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 2, 2017

Checked commit karelhala@a229feb with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@chessbyte chessbyte self-assigned this Nov 2, 2017
@chessbyte
Copy link
Member

@abonas LGTM. Will merge after your 👍

@abonas
Copy link
Member

abonas commented Nov 2, 2017

it LGTM, one question though @martinpovolny @chessbyte regarding miq_user_roles.yml - what kind of things should be added there? I don't see there a lot of middleware content/actions, mostly what this PR adds and some other single mention of mw entities. Wondering if this is redundant or alternatively there are other things missing there (unrelated to this PR)

@chessbyte
Copy link
Member

@abonas See http://talk.manageiq.org/t/product-features-and-roles/2855

@chessbyte
Copy link
Member

Merging. You can make more changes in follow-up PRs.

@chessbyte chessbyte merged commit 07a7684 into ManageIQ:master Nov 3, 2017
@chessbyte chessbyte added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 3, 2017
@chessbyte chessbyte changed the title Mw compliance assign Middleware compliance assignment Nov 3, 2017
@martinpovolny
Copy link
Member

@abonas Yes, please, see the article above. Btw, there's a note in
https://github.com/ManageIQ/guides/blob/master/ui/rbac_features.md too.

@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Adding gaprindashvili/yes to match #16375 and ManageIQ/manageiq-ui-classic#2595

simaishi pushed a commit that referenced this pull request Nov 7, 2017
@chessbyte @simaishi
Merge pull request #16376 from karelhala/mwComplianceAssign
b1913ed 
Mw compliance assign
(cherry picked from commit 07a7684)
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Gaprindashvili backport details:

$ git log -1
commit b1913edcfcfcd3fe6557df769c1e9183926377e7
Author: Oleg Barenboim <[email protected]>
Date:   Fri Nov 3 10:01:47 2017 -0400

    Merge pull request #16376 from karelhala/mwComplianceAssign
    
    Mw compliance assign
    (cherry picked from commit 07a7684bf9d74efe9dd4f1a24ad48a72dab6a254)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chessbyte chessbyte

Labels
enhancement gaprindashvili/backported providers/middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@karelhala @miq-bot @chessbyte @abonas @martinpovolny @simaishi