Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compliance check for MW server #16375

Merged
merged 2 commits into from
Nov 2, 2017

Conversation

karelhala
Copy link
Contributor

@karelhala karelhala commented Nov 1, 2017

This PR:

  • enables to add button in toolbar for starting simulation of policy for MW server and
  • enables Compliance and Policy for MW server
  • creates new events for compliance checks on MW server

Enabled button in toolbar

screenshot from 2017-11-02 14-32-39

Merge first

This PR is from set of PRs - ManageIQ/manageiq-ui-classic#2594

@karelhala
Copy link
Contributor Author

@miq-bot add_label enhancement, providers/middleware

@karelhala karelhala changed the title Enable compliance check for middleware server Enable compliance check for MW server Nov 1, 2017
@karelhala
Copy link
Contributor Author

@abonas can you please assign someone to review, test and merge?

@abonas
Copy link
Member

abonas commented Nov 2, 2017

@miq-bot add_label control

@abonas
Copy link
Member

abonas commented Nov 2, 2017

@miq-bot add_label gaprindashvili/yes

@abonas
Copy link
Member

abonas commented Nov 2, 2017

@karelhala the above says "adds button in toolbar " - is this the PR that adds that button? if yes, please add a screenshot here
LGTM
@agrare who would be the relevant reviewer/merger from core?

@karelhala
Copy link
Contributor Author

@abonas well it does not technically add it there, it just enables ui-classic to add it. I'll reword the description so it address it correctly.

@abonas
Copy link
Member

abonas commented Nov 2, 2017

@aljesusg please review

@martinpovolny
Copy link
Member

@karelhala : you should also add the permission to the relevant pre-defined roles in db/fixtures/miq_user_roles.yml

@martinpovolny martinpovolny self-assigned this Nov 2, 2017
@karelhala
Copy link
Contributor Author

@martinpovolny all done.
@abonas I have added option to check for compliance to all predefined roles, is that ok?

@miq-bot
Copy link
Member

miq-bot commented Nov 2, 2017

Checked commits karelhala/manageiq@8752a0f~...e189b2f with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@abonas
Copy link
Member

abonas commented Nov 2, 2017

@karelhala yes, we do not have any roles to exclude at the moment

@aljesusg
Copy link
Member

aljesusg commented Nov 2, 2017

LGFM

@martinpovolny martinpovolny merged commit 67cf171 into ManageIQ:master Nov 2, 2017
@martinpovolny martinpovolny added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 2, 2017
simaishi pushed a commit that referenced this pull request Nov 6, 2017
Enable compliance check for MW server
(cherry picked from commit 67cf171)
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit 8540f44d6972e0887f42d1937e633fd52432965c
Author: Martin Povolny <[email protected]>
Date:   Thu Nov 2 20:19:47 2017 +0100

    Merge pull request #16375 from karelhala/mwComplianceCheck
    
    Enable compliance check for MW server
    (cherry picked from commit 67cf1714f2158758b23964253d7a279e630a8801)

israel-hdez added a commit to israel-hdez/manageiq that referenced this pull request Dec 27, 2017
…Check"

Removes compliance check artifacts: events in control explorer, product,
features, association of product features to user roles.

This reverts commit 67cf171, reversing
changes made to 2ea04fa.

Related to BZ https://bugzilla.redhat.com/show_bug.cgi?id=1526791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants