-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable compliance check for MW server #16375
Conversation
@miq-bot add_label enhancement, providers/middleware |
bea8a94
to
969fca6
Compare
@abonas can you please assign someone to review, test and merge? |
@miq-bot add_label control |
@miq-bot add_label gaprindashvili/yes |
@karelhala the above says "adds button in toolbar " - is this the PR that adds that button? if yes, please add a screenshot here |
@abonas well it does not technically add it there, it just enables |
@aljesusg please review |
@karelhala : you should also add the permission to the relevant pre-defined roles in |
969fca6
to
e189b2f
Compare
@martinpovolny all done. |
Checked commits karelhala/manageiq@8752a0f~...e189b2f with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
@karelhala yes, we do not have any roles to exclude at the moment |
LGFM |
Enable compliance check for MW server (cherry picked from commit 67cf171)
Gaprindashvili backport details:
|
…Check" Removes compliance check artifacts: events in control explorer, product, features, association of product features to user roles. This reverts commit 67cf171, reversing changes made to 2ea04fa. Related to BZ https://bugzilla.redhat.com/show_bug.cgi?id=1526791
This PR:
Enabled button in toolbar
Merge first
This PR is from set of PRs - ManageIQ/manageiq-ui-classic#2594