Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C&U] fix bug in Targets#capture_vm_targets #16373

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Nov 1, 2017

introduced in eef58e1

specs in metric_capture exposed this

This will potentially not capture vms for C&U

introduced in eef58e1

specs in metric_capture expose
@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2017

Checked commit kbrock@bf03cf9 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @kbrock

@agrare agrare merged commit 7bee9ce into ManageIQ:master Nov 1, 2017
@agrare agrare added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 1, 2017
@kbrock kbrock deleted the fetch_collector_timer_ems_fix branch November 1, 2017 20:50
@kbrock kbrock mentioned this pull request Nov 2, 2017
5 tasks
@Fryguy Fryguy added the fine/yes label Nov 2, 2017
@Fryguy
Copy link
Member

Fryguy commented Nov 2, 2017

Marked fine/yes because the PR that introduced this #16004, is also fine/yes

simaishi pushed a commit that referenced this pull request Nov 6, 2017
[C&U] fix bug in Targets#capture_vm_targets
(cherry picked from commit 7bee9ce)
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit 03579dd4ca13781838871a2665871d502649873f
Author: Adam Grare <[email protected]>
Date:   Wed Nov 1 15:48:12 2017 -0400

    Merge pull request #16373 from kbrock/fetch_collector_timer_ems_fix
    
    [C&U] fix bug in Targets#capture_vm_targets
    (cherry picked from commit 7bee9ce4f3f01ecd8fb994a176e694b19dbe9422)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants