Metrics Worker capture_timer more ems centric #16004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating to running perf capture on all nodes (and ignoring alerts) This method now allows an option to ignore the alerts on a host and calculate the rollups regardless.
|
Checked commits kbrock/manageiq@e6a1c24~...eef58e1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/metric/targets.rb
|
5 tasks
|
@kbrock This PR has no BZ link, marked as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level
We are changing capacity & utilization:
before:
determine zone.vms --queue--> (collect and persist)after:
(determine ems.vms and collect) --queue--> persistThis change puts less load on the
queue. Additionally going from azonecentric flow to anemscentric flow allows us to optimize the way we callcollectthevms,hosts, andstorage.This PR
The current PR is focused on
determine vms, affectionately known asperf_capture_timer. It changes 10 helper methods to allow thevmsto be from azonecentric nature toemscentric. This allows the newMetricsCaptureWorker, which is ems centric, to reuse these methods.Numbers
For verification I benchmarked
perf_capture_timer, forcing alert detection on all objects, and triggering 'collection' for all objects.commentsbefore-2after-3* Memory usage does not reflect 2,277 freed objects
TL;DR: nothing changed