Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds vm_snapshot_success NotificationType #16286

Merged

Conversation

petrblaho
Copy link

@petrblaho petrblaho commented Oct 24, 2017

Adds vm_snapshot_success NotificationType so we can create notification when snapshot operation succeeds. This is used in ManageIQ/manageiq-providers-openstack#128

Partially solves https://bugzilla.redhat.com/show_bug.cgi?id=1429313

@miq-bot
Copy link
Member

miq-bot commented Oct 24, 2017

Checked commit petrblaho@fdd0dde with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@petrblaho
Copy link
Author

@skateman can you look at this please?

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@chessbyte chessbyte self-assigned this Oct 24, 2017
@chessbyte chessbyte merged commit 1d9af07 into ManageIQ:master Oct 24, 2017
@chessbyte chessbyte added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants