Adds vm_snapshot_success Notification creation #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aufi
suggested changes
Oct 25, 2017
There was a problem hiding this comment.
@petrblaho Thanks for PR, I'm getting following error
ActiveModel::UnknownAttributeError: unknown attribute 'snapshot_op' for Notification.
|
@aufi good catch, thank you. My bad for sure... Updating in a minute... |
|
Checked commits https://github.com/petrblaho/manageiq-providers-openstack/compare/65c6ea93bff7aa580421de8e61decd53eb35409e~...66be7bd394d8977ff9c317d46e77ddb6a42df745 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
aufi
approved these changes
Oct 25, 2017
|
Works, looks good to me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates notification with
vm_snapshot_successtype with Vm assubjectforcreateandremoveassnapshot_op.Notification Type is defined in ManageIQ/manageiq#16286 which is needed for this one.
Partially solves https://bugzilla.redhat.com/show_bug.cgi?id=1429313