Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Container Component Statuses #16055

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Drop Container Component Statuses #16055

merged 1 commit into from
Oct 3, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Sep 27, 2017 •
edited
Loading

@zakiva zakiva mentioned this pull request Sep 27, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Sep 27, 2017

Checked commit zakiva@92b97ce with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@zakiva
Copy link
Contributor Author

zakiva commented Sep 27, 2017

@simon3z @cben @zeari Please review

@zakiva
Copy link
Contributor Author

zakiva commented Sep 27, 2017

@miq-bot add_label providers/containers, cleanup

cben
cben reviewed Sep 27, 2017
View reviewed changes
Copy link
Contributor

@cben cben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM ✂️ 🔥 ✂️ 🔥 ✂️

Please describe in which order those should be merged.

moolitayer
moolitayer approved these changes Sep 28, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simon3z
Copy link
Contributor

simon3z commented Sep 28, 2017

Pending on a question about schema which I believe is related (let me know if this can be decoupled from that discussion).

@moolitayer moolitayer mentioned this pull request Sep 28, 2017
Merged
@moolitayer
Copy link

@zakiva next time it's helpful to have all the links from all the PRs (You can create issues with all the info and link to them if you like).

@Fryguy Fryguy merged commit ee688dc into ManageIQ:master Oct 3, 2017
@Fryguy Fryguy added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 3, 2017
@Fryguy Fryguy self-assigned this Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cben cben cben left review comments

@moolitayer moolitayer moolitayer approved these changes

Assignees

@Fryguy Fryguy

Labels
providers/containers technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zakiva @miq-bot @simon3z @moolitayer @cben @Fryguy