Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Container Component Statuses #79

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Drop Container Component Statuses #79

merged 1 commit into from
Oct 3, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Sep 27, 2017 •
edited
Loading

This was referenced Sep 27, 2017
Merged
Merged
@zakiva
Copy link
Contributor Author

zakiva commented Sep 27, 2017

@simon3z @cben @zeari Please review

@zakiva
Copy link
Contributor Author

zakiva commented Sep 27, 2017

@miq-bot add_label cleanup

@miq-bot
Copy link
Member

miq-bot commented Sep 27, 2017

Checked commit zakiva@03ac36d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@cben
Copy link
Contributor

cben commented Sep 27, 2017

Please describe in which order those should be merged.

moolitayer
moolitayer approved these changes Sep 28, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simon3z
Copy link
Contributor

simon3z commented Sep 28, 2017

@zakiva @cben @moolitayer do we want to remove this down to the schema (as this PR is doing) or do we think that keeping it would be nice if in the future it is properly implemented on the OpenShift side?

I am OK to remove this (also because future implementation is not laid out yet) but I also know that this is a nice OpenShift feature that may be scheduled for one of the upcoming releases.

@moolitayer
Copy link

I don't have a strong preference. 👍 to remove.

I think this PR depends on ManageIQ/manageiq#16055 (removing the class definition)

@cben
Copy link
Contributor

cben commented Sep 28, 2017

I also lean towards removing.
But schema is special, because re-adding it won't be backportable. Is there chance we'll want to re-add it in z-streams?

@simon3z
Copy link
Contributor

simon3z commented Sep 28, 2017

But schema is special, because re-adding it won't be backportable. Is there chance we'll want to re-add it in z-streams?

@cben no chance but also deleting it in this release to re-add it next release seems an overhead (although, again, we do not have details on the future implementation, we may have to add many new fields).

@Fryguy
Copy link
Member

Fryguy commented Oct 2, 2017

I'm ok with deleting now and adding back later. There's a good chance you'll have different columns anyway.

@Fryguy Fryguy merged commit d687a42 into ManageIQ:master Oct 3, 2017
@Fryguy Fryguy added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 3, 2017
@Fryguy Fryguy self-assigned this Oct 3, 2017
d-m-u added a commit to d-m-u/manageiq-schema that referenced this pull request Jun 29, 2020
@d-m-u
bump more core extentions
91735cb 
more core ext's on 4.1.0

update for update sake

https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)]
 - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)]

array added * `#compact_map` - Collect non-nil results from the block
array added `#tabular_sort` - Sorts an Array of Hashes by specific columns

hierarchy added `#descendant_get` - Returns the descendant with a given name

the two breaking changes:
- **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)]
- **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)]

a minor header output change was made that hasn't been released yet to make tableize more markdown compliant

see ManageIQ/linux_admin#221
d-m-u added a commit to d-m-u/manageiq-schema that referenced this pull request Jul 9, 2020
@d-m-u
bump more core extentions
788b7a4 
more core ext's on 4.1.0

update for update sake

https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)]
 - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)]

array added * `#compact_map` - Collect non-nil results from the block
array added `#tabular_sort` - Sorts an Array of Hashes by specific columns

hierarchy added `#descendant_get` - Returns the descendant with a given name

the two breaking changes:
- **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)]
- **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)]

a minor header output change was made that hasn't been released yet to make tableize more markdown compliant

see ManageIQ/linux_admin#221
d-m-u added a commit to d-m-u/manageiq-schema that referenced this pull request Jul 10, 2020
@d-m-u
bump more core extentions
4f77fd2 
more core ext's on 4.1.0

update for update sake

https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)]
 - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)]

array added * `#compact_map` - Collect non-nil results from the block
array added `#tabular_sort` - Sorts an Array of Hashes by specific columns

hierarchy added `#descendant_get` - Returns the descendant with a given name

the two breaking changes:
- **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)]
- **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)]

a minor header output change was made that hasn't been released yet to make tableize more markdown compliant

see ManageIQ/linux_admin#221
d-m-u added a commit to d-m-u/manageiq-schema that referenced this pull request Jul 14, 2020
@d-m-u
bump more core extentions
267ba56 
more core ext's on 4.1.0

update for update sake

https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
 - Added Ruby 2.7 support [[ManageIQ#79](ManageIQ/more_core_extensions#79)]
 - Added Process#pause, Process#resume, and Process#alive? [[ManageIQ#73](ManageIQ/more_core_extensions#73)]

array added * `#compact_map` - Collect non-nil results from the block
array added `#tabular_sort` - Sorts an Array of Hashes by specific columns

hierarchy added `#descendant_get` - Returns the descendant with a given name

the two breaking changes:
- **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ManageIQ#75](ManageIQ/more_core_extensions#75)]
- **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ManageIQ#76](ManageIQ/more_core_extensions#76)]

a minor header output change was made that hasn't been released yet to make tableize more markdown compliant

see ManageIQ/linux_admin#221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moolitayer moolitayer moolitayer approved these changes

@cben cben cben approved these changes

@simon3z simon3z simon3z approved these changes

Assignees

@Fryguy Fryguy

Labels
schema technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zakiva @miq-bot @cben @simon3z @moolitayer @Fryguy