-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RBAC rules for the help screen (about, documentation, product) #16003
Conversation
Looks good to me. ping @dclarizio : do you like these texts? |
@skateman @martinpovolny Also, the order should match the way they appear in the UI, so doc/product/about. |
@dclarizio the RBAC tree is rendered based on the menu declaration, so even if I declare a top level item here, it would not do anything at all. |
@skateman It will do something in that the features tree in the role editor will turn off all 3 if the parent is unchecked and the parent will get partially checked if any one of the 3 children is checked. So, visually, to the user, they will understand that the Help menu will totally disappear if all 3 are turned off. |
db/fixtures/miq_product_features.yml
Outdated
# Documentation | ||
- :name: Documentation | ||
:description: Open the documentation page | ||
:feature_type: node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skateman I just looked at other items in the file and the Descriptions are normally done like titles, so these should be:
- Open the Documentation Page
- Open the Product Website
- Show the About Information
Checked commit skateman@82f49ec with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
RBAC rules created for these buttons in the top right menu:
Pivotal story: https://www.pivotaltracker.com/story/show/150933794
@martinpovolny my copy-paste skills aren't so strong, am I doing this right?