Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RBAC rules for the help screen (about, documentation, product) #16003

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

skateman
Copy link
Member

RBAC rules created for these buttons in the top right menu:
screenshot from 2017-09-20 20-01-25

Pivotal story: https://www.pivotaltracker.com/story/show/150933794

@martinpovolny my copy-paste skills aren't so strong, am I doing this right?

@martinpovolny
Copy link
Member

Looks good to me.

ping @dclarizio : do you like these texts?

@dclarizio
Copy link

@skateman @martinpovolny
Looks good, except I think we need a "Help" parent node so they entire menu can be toggled easily.

Also, the order should match the way they appear in the UI, so doc/product/about.

@skateman
Copy link
Member Author

@dclarizio the RBAC tree is rendered based on the menu declaration, so even if I declare a top level item here, it would not do anything at all.

@dclarizio
Copy link

@skateman It will do something in that the features tree in the role editor will turn off all 3 if the parent is unchecked and the parent will get partially checked if any one of the 3 children is checked. So, visually, to the user, they will understand that the Help menu will totally disappear if all 3 are turned off.

# Documentation
- :name: Documentation
:description: Open the documentation page
:feature_type: node

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skateman I just looked at other items in the file and the Descriptions are normally done like titles, so these should be:

  • Open the Documentation Page
  • Open the Product Website
  • Show the About Information

@miq-bot
Copy link
Member

miq-bot commented Sep 21, 2017

Checked commit skateman@82f49ec with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@dclarizio dclarizio merged commit 4273cac into ManageIQ:master Sep 21, 2017
@dclarizio dclarizio added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 21, 2017
@skateman skateman deleted the help-rbac branch October 11, 2017 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants