Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load help menu from the default menu #2198

Merged
merged 5 commits into from
Sep 22, 2017
Merged

Conversation

skateman
Copy link
Member

@skateman skateman commented Sep 20, 2017

Taking over @martinpovolny's #2192:

  • Help menu now defined in the default_menu
  • Menu::Item and Menu::Section now specify a more generic link_params instead of an url
  • Using the link_params two new link types have been created: modal and new_window

RBAC depends on ManageIQ/manageiq#16003, but its tree hierarchy is described here.

screenshot from 2017-09-21 16-12-18

Pivotal story: https://www.pivotaltracker.com/story/show/150933794
@miq-bot add_label enhancement, fine/no

@miq-bot
Copy link
Member

miq-bot commented Sep 22, 2017

Checked commits skateman/manageiq-ui-classic@1051900~...7526130 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 3 offenses detected

app/presenters/menu/default_menu.rb

  • ❗ - Line 280, Col 11 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❗ - Line 281, Col 147 - Rails/OutputSafety - Tagging a string as html safe may be a security risk, prefer safe_join or other Rails tag helpers instead.
  • ❗ - Line 283, Col 9 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

@mzazrivec mzazrivec self-assigned this Sep 22, 2017
@mzazrivec mzazrivec added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 22, 2017
@mzazrivec mzazrivec merged commit 0af0d40 into ManageIQ:master Sep 22, 2017
@skateman skateman deleted the help-menu branch September 22, 2017 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants