Create embedded ansible deployment on demand #15963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #15962 |
|
This pull request is not mergeable. Please rebase and repush. |
carbonin
force-pushed
the
enhance_embedded_ansible_container
branch
from
331f3ee to
7d7fd91
Compare
|
This pull request is not mergeable. Please rebase and repush. |
carbonin
force-pushed
the
enhance_embedded_ansible_container
branch
from
7d7fd91 to
23fe44b
Compare
|
This pull request is not mergeable. Please rebase and repush. |
carbonin
force-pushed
the
enhance_embedded_ansible_container
branch
from
0b73157 to
7c72872
Compare
carbonin
force-pushed
the
enhance_embedded_ansible_container
branch
2 times, most recently
from
80449f6 to
f7104f3
Compare
carbonin
force-pushed
the
enhance_embedded_ansible_container
branch
3 times, most recently
from
f40d600 to
404f510
Compare
carbonin
changed the title
carbonin
force-pushed
the
enhance_embedded_ansible_container
branch
from
404f510 to
1ed2556
Compare
carbonin
force-pushed
the
enhance_embedded_ansible_container
branch
from
1ed2556 to
2068bdf
Compare
|
Checked commits carbonin/manageiq@c3da7df~...2068bdf with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the handling of embedded ansible when running in a container.
Before, we would just scale an existing deployment when we are running in a container but we don't really want to unconditionally create a deployment that we may not use.
After this PR, we will create the deployment and all the other dependent objects required to run containerized embedded ansible when the role is enabled.
This includes moving things like secret and password generation into our app rather than relying on OpenShift generators to create and store them for us.