Remove the embedded ansible objects from the template #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These objects will be created by the server process as they are needed. This way we can control what images are used and how they are deployed from the ManageIQ code base rather than maintaining templates. Additionally, users who are not using the embedded ansible role will no-longer have an unused deployment config sitting in the project
|
Checked commit carbonin@09370fa with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
Requires ManageIQ/manageiq#15963 |
carbonin
changed the title
bdunne
approved these changes
Jan 12, 2018
carbonin
added a commit
to carbonin/manageiq-pods
that referenced
this pull request
May 24, 2018
This backports ManageIQ#256 to Hammer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These objects will be created by the server process as they are
needed.
This way we can control what images are used and how they are deployed
from the ManageIQ code base rather than maintaining templates.
Additionally, users who are not using the embedded ansible role
will no-longer have an unused deployment config sitting in the project