raise not found error on DELETE of authentications

[jntullo]

DELETE /api/authentications/:id should raise a not found for invalid authentications. It is currently sending back a 204 as if it's a success due to the catching of the exception and returning it as an action result.

This is inconsistent with other areas of the API where DELETE returns a not found for invalid records.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1476869

@miq-bot add_label bug, api
@miq-bot assign @abellotti

[miq-bot]

Checked commit jntullo@050aaf9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[abellotti]

hmm, for action returns signatures, don't we always return that signature ? i.e. if the 4th out of 10 resources in a bulk operation does not exist do we return a not found for the whole lot or just the 4th resource (i.e. as it is done now)

[jntullo]

@abellotti this isn't for bulk operations, it's just for DELETE. Bulk operations will remain the same, which is just returning the action response. But for DELETE it is acting as if the resource was found due to the action response, which it is not, and this change corrects that.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.