raise not found error on DELETE

[jntullo]

manageiq-api version of ManageIQ/manageiq#15736

DELETE /api/authentications/:id should raise a not found for invalid authentications. It is currently sending back a 204 as if it's a success due to the catching of the exception and returning it as an action result.

This is inconsistent with other areas of the API where DELETE returns a not found for invalid records.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1476869

@miq-bot add_label bug
@miq-bot assign @abellotti

[abellotti]

@jntullo can you take care of the codeclimate issues ?

[jntullo]

@abellotti I'm not too sure I agree with codeclimate here. While this code does have some duplication, it's not something I feel should be abstracted

[jntullo]

@abellotti also noticed I didn't even touch the lines it's complaining about 😕

[imtayadeway]

Hi! It looks like your PR has been affected by the recently merged #40, and as a result will need to be rebased. First, I apologize for any inconvenience caused. After rebasing, you'll need to update some specs in order for them to pass. In particular you'll need to change any path helpers, applying the following pattern:

vms_url => api_vms_url
vms_url(vm.id) => api_vm_url(nil, vm) 
vms_url(vm.compressed_id) => api_vm_url(nil, vm.compressed_id)
"#{vms_url(vm.id)}/tags" => api_vm_tags_url(nil, vm)
"#{vms_url(vm.compressed_id}/tags" => api_vm_tags_url(nil, vm.compressed_id)
"#{vms_url(vm.id)}/tags/#{tag.id}" => api_vm_tag_url(nil, vm, tag)
"#{vms_url(vm.compressed_id)}/tags/#{tag.compressed_id}" => api_vm_tag_url(nil, vm.compressed_id, tag.compressed_id)

If you run into any issues, please ping me and I will try to help you out.

Many thanks!
Tim

[miq-bot]

Checked commit jntullo@46aa4e2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[abellotti]

Thanks @jntullo for updating to use the api rails url helper. will merge when 🍏

[abellotti]

LGTM!!