[FINE] [SCVMM] Update cloning powershell script #15610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
djberg96
changed the title
|
@miq-bot add_label euwe/yes |
|
This one works for 5.8.1. I tested 6 difference combinations and they all worked, specifically checking for the new static IP and making sure all other choices were still being applied. |
|
Note that the failures appear to be unrelated OpenStack issues. |
simaishi
changed the title
|
Marked as WIP, as the 'master' PR this is based on isn't merged yet. |
djberg96
changed the title
|
@miq-bot remove_label wip |
|
Merged on master |
bronaghs
approved these changes
Jul 21, 2017
|
This pull request is not mergeable. Please rebase and repush. |
|
Checked commit https://github.com/djberg96/manageiq/commit/9c6921ec7069787b4296f9217ac204eb38de2e46 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
added a commit
that referenced
this pull request
Aug 15, 2017
[FINE] [SCVMM] Update cloning powershell script (cherry picked from commit d9620de) https://bugzilla.redhat.com/show_bug.cgi?id=1481865
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where there appears to be a race condition that results in static IP assignment failing when using provisioning from a pool if we use New-SCVirtualMachine. Instead, this approach is to create a configuration object, then apply the configuration.
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1463019
This is a separate PR for Fine based on ManageIQ/manageiq-providers-scvmm#9