This repository has been archived by the owner on Jul 25, 2023. It is now read-only.
Revamp create_vm_script to use configuration #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/djberg96/manageiq-providers-scvmm/commit/ed4e21a2e84c7016a53698a17964184a6e507221 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
BTW, the errors are unrelated and are the result of a change in the underlying logging classes. |
djberg96
changed the title
|
@miq-bot remove_label wip |
|
@miq-bot add_label fine/no |
|
@jteehan tested this in ManageIQ/manageiq#15610. Merging based on his successful tests. |
|
Backported to Fine via ManageIQ/manageiq#15610 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where there appears to be a race condition that results in static IP assignment failing when using provisioning from a pool if we use
New-SCVirtualMachine. Instead, this approach is to create a configuration object, then apply the configuration.Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1463019