Drop deprecated attribute 'Host#address'

[kbrock]

Our TravisCI tests are generating deprecation warnings:

It was introduced by #14138

This removes them.

DEPRECATION WARNING:
address is deprecated and will be removed from ManageIQ G-release (hostname)
(called from block in ems_host_list at
/home/travis/build/ManageIQ/manageiq/app/models/vm_or_template.rb:792)

DEPRECATION WARNING:
address is deprecated and will be removed from ManageIQ G-release (hostname)
(called from new at
/home/travis/build/ManageIQ/manageiq/app/models/mixins/vim_connect_mixin.rb:22)

/cc @juliancheal Is this the solution you had in mind?
/cc @abellotti Does this affect the API (thinking no)
/cc @agrare Does the fix to vim_connect_mixin.rb look right to you? Or just drop the || part?

[agrare]

@kbrock definitely still need the || since most callers don't pass options (e.g.: remote_console_vmrc_acquire_ticket and find_vm_create_events)
The change to vim_connect_mixin looks good, do you need the self. though?

[agrare]

@kbrock yes a hostname will work, options[:ip] is badly named, any IP or dns name will work.

[miq-bot]

Checked commit kbrock@501f663 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

[agrare]

👍