Deprecate callers to Address in Host #14138
Conversation
juliancheal
force-pushed
the
deprecate_mixin
branch
from
c1dc615 to
e018bc5
Compare
|
@miq-bot add_label wip |
juliancheal
force-pushed
the
deprecate_mixin
branch
from
e018bc5 to
87de036
Compare
|
This PR is a replacement of #9204 as just removing all the callers to a method is hard, as there maybe some callers we don't yet know about. |
|
@juliancheal There already is a mixin for deprecations at app/models/mixins/deprecation_mixin.rb Can you reuse that file or does it already do what you need? |
Ah thanks for the heads up. This looks good. I think think we should log that a method is being deprecated. I'll update the PR. |
|
Coolio, so we do log deprecations, but we list them as being removed in F release. What if we're going to depreciated something in the future in an unknown release? https://github.com/ManageIQ/manageiq/blob/master/lib/vmdb/deprecation.rb#L4 /cc @bdunne |
juliancheal
changed the title
|
@juliancheal When we cut the F branch, we change that to the next version |
|
@Fryguy ha that was my guess. |
We tried simply removing it before, but we think some automate users may be using it, even though the tests pasted.
juliancheal
force-pushed
the
deprecate_mixin
branch
from
ae8b53c to
4f709fb
Compare
|
Squashed commits to reflect this PR better. |
|
Checked commit juliancheal@4f709fb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot remove_label wip |
miq-bot
changed the title
Wraps address in deprecated alias_attribute.