Avoid Tower in notifications for embedded ansible #15478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManageIQ should not indicate that anything "Tower" exists when dealing
with Embedded Ansible. This should change the logs and notifications to
use a more "embedded ansibly" term when talking about embedded ansibly
things.
Before:
"The operation Ansible Tower Credential creation (name=...) on Tower
^^^^^^^^^^^^^
(manager_id=...) completed successfully."
After:
"The operation Ansible Automation Inside Credential creation (name=...)
^^^^^^^^^^^^^^^^^^^^^^^^^
on EMS(manager_id=1) completed successfully."
https://bugzilla.redhat.com/show_bug.cgi?id=1458593
jameswnl
approved these changes
Jun 29, 2017
|
Checked commit blomquisg@f664b19 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 4, 2017
Avoid Tower in notifications for embedded ansible (cherry picked from commit 2b6dd95) https://bugzilla.redhat.com/show_bug.cgi?id=1478429
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Avoid Tower in notifications for embedded ansible (cherry picked from commit 2b6dd95) https://bugzilla.redhat.com/show_bug.cgi?id=1478429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManageIQ should not indicate that anything "Tower" exists when dealing with Embedded Ansible. This should change the logs and notifications to use a more "embedded ansibly" term when talking about embedded ansibly things.
Before:
After:
https://bugzilla.redhat.com/show_bug.cgi?id=1458593
see also: ManageIQ/manageiq-providers-ansible_tower#10