-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Tower in notifications for embedded ansible #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswnl
approved these changes
Jun 29, 2017
@blomquisg can you update the spec tests to match the new notification string? |
ManageIQ should not indicate that anything "Tower" exists when dealing with Embedded Ansible. This should change the logs and notifications to use a more "embedded ansibly" term when talking about embedded ansibly things. Before: "The operation Ansible Tower Credential creation (name=...) on Tower(manager_id=...) completed successfully." ^^^^^ After: "The operation Ansible Automation Inside Credential creation (name=...) on EMS(manager_id=1) completed successfully." ^^^ https://bugzilla.redhat.com/show_bug.cgi?id=1458593
blomquisg
force-pushed
the
tower_not_tower
branch
from
July 17, 2017 21:04
92671ac
to
bc16c7c
Compare
Checked commits blomquisg/manageiq-providers-ansible_tower@9683ab6~...bc16c7c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Jul 17, 2017
@agrare updated |
@blomquisg I assume this should be |
Fine backport (to manageiq repo) details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManageIQ should not indicate that anything "Tower" exists when dealing
with Embedded Ansible. This should change the logs and notifications to
use a more "embedded ansibly" term when talking about embedded ansibly
things.
Before:
After:
https://bugzilla.redhat.com/show_bug.cgi?id=1458593
see also: ManageIQ/manageiq#15478