-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch saving strategy should populate the right timestamps #15394
Merged
agrare
merged 6 commits into
ManageIQ:master
from
Ladas:batch_saving_strategy_should_populate_the_right_timestamps
Jun 20, 2017
Merged
Batch saving strategy should populate the right timestamps #15394
agrare
merged 6 commits into
ManageIQ:master
from
Ladas:batch_saving_strategy_should_populate_the_right_timestamps
Jun 20, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@miq-bot add_label enhancement |
Batch saving strategy should populate the right timestamps
Supports helpers for timestamp attributes
Supports helper for remote_data_timetamp
Ladas
force-pushed
the
batch_saving_strategy_should_populate_the_right_timestamps
branch
from
June 20, 2017 13:02
4b43988
to
24c5d07
Compare
Use supports_remote_data_timestamp? in sql helper
Extract assignment of a common attributes to a base class
Use Time.zone.now instead of localtime
Ladas
force-pushed
the
batch_saving_strategy_should_populate_the_right_timestamps
branch
from
June 20, 2017 13:07
24c5d07
to
193dd12
Compare
Checked commits Ladas/manageiq@8afc38b~...193dd12 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
approved these changes
Jun 20, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
agrare
added a commit
that referenced
this pull request
Jun 20, 2017
…ulate_the_right_timestamps Batch saving strategy should populate the right timestamps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch saving strategy should populate the right timestamps