Optimize insert query loading #15404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
Add Returning clause if the IC has dependees
Use INSERT query result if possible. If we are sure that all ids of inserted records are in the result, we can use it and spare time loading the records back from the db.
Ladas
force-pushed
the
optimize_insert_query_loading
branch
from
b3be700 to
b4330a8
Compare
|
Checked commits Ladas/manageiq@74c72f8~...b4330a8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manager_refresh/save_collection/saver/sql_helper.rb
|
agrare
reviewed
Jun 22, 2017
| # we test if the number of results matches the expected batch size. Then if the counts do not match, the only | ||
| # safe option is to query all the data from the DB, using the unique_indexes. The batch size will also not match | ||
| # for every remainders(a last batch in a stream of batches) | ||
| if !supports_remote_data_timestamp?(all_attribute_keys) || result.count == batch_size |
There was a problem hiding this comment.
@Ladas is it possible the count could be the same as the batch size but still not return the "correct" ids?
There was a problem hiding this comment.
it should not be, we check for uniqueness at least like on 2 places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize insert query loading, using a Returning clause properly. This way we can spare another query for loading back the data. We need to load back the inserted data, to get their primary keys.