Fixed logging for proxy when storage not defined #15028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
fix-proxy-logging-when0-storage-not-setup
branch
from
d43db58 to
e9f8f69
Compare
|
Checked commit yrudman@e9f8f69 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM, however I think this is a prime target for the Null Object Pattern: https://robots.thoughtbot.com/rails-refactoring-example-introduce-null-object |
Fryguy
reviewed
May 9, 2017
| else | ||
| "No storage" | ||
| end | ||
| msg |
There was a problem hiding this comment.
Style:
- Avoid the line continuation
\...just make it a single line. - Prefer
<<over+= - There's no need to append and then return the variable, it can be done in one shot
def log_proxies_vm_config
msg = "[#{log_proxies_format_instance(self)}] on host [#{log_proxies_format_instance(host)}] #{ui_lookup(:table => "storages").downcase} "
msg << storage ? "[#{storage.name}-#{storage.store_type}]" : "No storage"
endThere was a problem hiding this comment.
@Fryguy OK, it does look cleaner, will change it in PR removing not used log_proxies
|
I merged to get the repos green, but I do have a comment about the code style, which could be done in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging #15009 cause UI spec failing when attempting to log not existing storage.
Fix: check for nil before attempting to log storage info
@miq-bot add-label bug
\cc @jrafanie