Remove reference to job.guid from VmOrTemplate #15009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are instances of MiqServer and does not depend on 'job'. proxy can not be instance of Host and we do not need to check for registred hosts
…s of SmartState proxy through registered hosts: proxy can not be instance of Host - only MiqServer $rspec: no need for tests SmartState proxy through registered hosts
yrudman
force-pushed
the
remove-reference-to-job-guid-from-vm
branch
from
c8a7238 to
8758d7b
Compare
yrudman
changed the title
jrafanie
reviewed
May 5, 2017
|
|
||
| log_all_proxies(all_proxy_list, msg) if proxies.empty? |
There was a problem hiding this comment.
Can log_proxies be removed down below? Are there other callers?
There was a problem hiding this comment.
Follow-up PR will remove not used VmOrTemplate#log_proxies and replace call to it to log_all_proxies for redhat provider
Lol, now I see it, sorry
jrafanie
reviewed
May 5, 2017
| if job && !job.kind_of?(ActiveRecord::Base) | ||
| jobid = job | ||
| job = Job.find_by(:guid => jobid) | ||
| end |
There was a problem hiding this comment.
Wow, we do all that work with the job just for logging... Nice find. We don't need it.
jrafanie
reviewed
May 5, 2017
| elsif proxies.empty? | ||
| "Provide credentials for this VM's Host to perform SmartState Analysis" | ||
| else | ||
| 'Perform SmartState Analysis on this VM' |
yrudman
force-pushed
the
remove-reference-to-job-guid-from-vm
branch
from
a266405 to
ee3d7e0
Compare
|
Checked commits yrudman/manageiq@17e8652~...ee3d7e0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This was referenced May 8, 2017
yrudman
added a commit
to yrudman/manageiq
that referenced
this pull request
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to include
job.guidinto error message when proxy for smart state analysis not available - proxy is instance ofMiqServerand does not depend on job instance.This PR:
VmOrTemplate#log_all_proxies' which does not acceptjob`jobHostbeen proxy for SmartState AnalysisFollow-up PR will remove not used
VmOrTemplate#log_proxiesand replace call to it tolog_all_proxiesforredhatprovider@miq-bot add-label technical debt