Add policy checking for retirement request. #14641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
reviewed
Apr 4, 2017
| @@ -153,6 +153,14 @@ def self.miq_event_enforce_policy(obj, _inputs) | |||
| event_object_from_workspace(obj).process_evm_event | |||
| end | |||
|
|
|||
| def self.miq_check_policy_prevent(obj, _inputs) | |||
There was a problem hiding this comment.
@lfu
Can we add a spec for this method.
lfu
force-pushed
the
prevent_retirement_request
branch
from
0ecc13e to
5761dc0
Compare
lfu
force-pushed
the
prevent_retirement_request
branch
from
5761dc0 to
6b74aa4
Compare
mkanoor
approved these changes
Apr 6, 2017
|
@lfu Looks good. |
gmcculloug
reviewed
Apr 7, 2017
| @@ -166,6 +166,11 @@ request_service_stop,Service Stop Request,Default,service_process | |||
| service_stopped,Service Stopped,Default,service_process | |||
|
|
|||
| # | |||
| # Orchestration | |||
| # | |||
| request_orchestration_stack_retire,Orchestration Stack Retire Request,Default,orchestration | |||
There was a problem hiding this comment.
@lfu This needs a corresponding miq_event_definition_set instance for orchestration added to db/fixtures/miq_event_definition_sets.csv.
Following the existing pattern for VM and Service the set should be called orchestration_process
lfu
force-pushed
the
prevent_retirement_request
branch
from
6b74aa4 to
67db0f4
Compare
|
Checked commits lfu/manageiq@d26ec21~...67db0f4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
gmcculloug
approved these changes
Apr 7, 2017
|
@lfu Please open a git issue in the UI repo to add an icon for this event. It currently shows the default ⭐️ icon.
Probably want to use something like the stack icon from the
|
simaishi
pushed a commit
that referenced
this pull request
Apr 7, 2017
Add policy checking for retirement request. (cherry picked from commit 302e14c) https://bugzilla.redhat.com/show_bug.cgi?id=1440324
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 17, 2017
Add policy checking for retirement request. (cherry picked from commit 302e14c) https://bugzilla.redhat.com/show_bug.cgi?id=1440402
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All events are sent to automate for processing since Event Switchboard PR.
Since then the policy checking for prevent action has changed from a sync process to an async process.
Depends on #86.
https://bugzilla.redhat.com/show_bug.cgi?id=1439331
@miq-bot assign @gmcculloug
@miq-bot add_label bug, control, darga/yes, euwe/yes, automate, fine/yes