Policy to prevent Tag/Untag does not work

[cben]

1. Created a container node policy with Tag Request and UnTag Request events.
2. Added Prevent current event from proceeding action.
3. Created & assigned policy profile so the policy is active.
4. Edit Tags in UI — added a tag, saved, removed, saved.

Expected: The tag is not added, nor removed.
Actual: https://gist.github.com/cben/fa09fbb6760531a30a725d9f66df2d4f — policy.log looks great, the Prevent action runs, but the tag was still added/removed!

@miq-bot add-labels control, bug

[cben]

@lfu I see you did 2 fixes #14427 #14641 about Prevent not working — do you think similar fix would apply for [Un]Tag Request?
The current tag policy checking code is:
https://github.com/ManageIQ/manageiq/blob/8da73f2cf8e1a5/app/models/classification.rb#L286

[lfu]

@cben Tag event should not be prevented from policy as doing so may hit performance issue.

[cben]

If so, Tag Request event has no purpose and should be dropped?

…

On Aug 23, 2017 22:32, "Lucy Fu" ***@***.***> wrote: @cben <https://github.com/cben> Tag event should not be prevented from policy as doing so may hit performance issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15882 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQtGAeaOIA3FXqJtEZm_9d31dPgQcv1ks5sbH4vgaJpZM4PAX0o> .

[lfu]

@gmcculloug @Fryguy Thoughts?

[bronaghs]

@miq-bot assign @lfu

[Fryguy]

¯\_(ツ)_/¯ @gtanzillo ?

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[JPrause]

@cben is this still a valid issue. If not can you close.
If there's no update by next week, I'll be closing this issue.

[cben]

@miq-bot remove-label stale

Didn't retest but I assume this wasn't magically fixed.
@gtanzillo @gmcculloug @Fryguy should request_assign_company_tag, request_unassign_company_tag events be removed? They're pointless & misleading if "Prevent current event" action has no effect, right?
@lfu says above #15882 (comment) making Prevent work would have problematic performance.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[JPrause]

@miq-bot remove_label stale
@miq-bot add_label pinned

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.