Added new firmware collection api

app/controllers/api/firmwares_controller.rb

@@ -0,0 +1,4 @@
+module Api
+  class FirmwaresController < BaseController
+  end
+end

config/api.yml

@@ -685,6 +685,25 @@
       :post:
       - :name: assign
       - :name: unassign
+  :firmwares:
+    :description: Firmwares
+    :options:
+    - :collection
+    - :subcollection
+    :verbs: *gp
+    :klass: Firmware
+    :identifier: firmware
+    :collection_actions:
+      :get:
+      - :name: read
+        :identifier: firmware_show_list
+      :post:
+      - :name: query
+        :identifier: firmware_show_list
+    :resource_actions:
+      :get:
+      - :name: read
+        :identifier: firmware_show
   :flavors:
     :description: Flavors
     :identifier: flavor

db/fixtures/miq_product_features.yml

@@ -6419,6 +6419,26 @@
       :feature_type: control
       :identifier: physical_server_refresh
 
+# Firmwares
+- :name: Firmwares
+  :description: Everything under Firmware 
+  :feature_type: node
+  :identifier: firmware
+  :children:
+  - :name: View
+    :description: View Firmware
+    :feature_type: view
+    :identifier: firmware_view
+    :children:
+    - :name: List
+      :description: Display Lists of Firmware
+      :feature_type: view
+      :identifier: firmware_show_list
+    - :name: Show
+      :description: Display Individual Firmware
+      :feature_type: view
+      :identifier: firmware_show
+
 # Physical Infrastructure Topology
 - :name: Physical Infra Topology
   :description: Physical Infra Topology

spec/factories/firmware.rb

@@ -0,0 +1,4 @@
+FactoryGirl.define do
+  factory :firmware do
+  end
+end

spec/requests/api/collections_spec.rb

@@ -303,6 +303,11 @@ def test_collection_bulk_query(collection, collection_url, klass, id = nil)
       FactoryGirl.create(:miq_alert_status)
       test_collection_query(:alerts, alerts_url, MiqAlertStatus)
     end
+
+    it 'query Firmwares' do
+      FactoryGirl.create(:firmware)
+      test_collection_query(:firmwares, firmwares_url, Firmware)
+    end
   end
 
   context "Collections Bulk Queries" do
@@ -558,5 +563,10 @@ def test_collection_bulk_query(collection, collection_url, klass, id = nil)
       FactoryGirl.create(:cloud_volume)
       test_collection_bulk_query(:cloud_volumes, cloud_volumes_url, CloudVolume)
     end
+
+    it 'bulk query Firmwares' do
+      FactoryGirl.create(:firmware)
+      test_collection_bulk_query(:firmwares, firmwares_url, Firmware)
+    end
   end
 end

spec/requests/api/firmwares_spec.rb

@@ -0,0 +1,31 @@
+RSpec.describe "firmwares API" do
+  describe "display firmware details" do
+    context "with a valid role" do
+      it "shows its properties" do
+        fw = FactoryGirl.create(:firmware, :id => 1, :name => "UEFI",
+                                :version => "D7E152CUS-2.11", :resource_id => 1)
+
+        api_basic_authorize action_identifier(:firmwares, :read, :resource_actions, :get)
+
+        run_get(firmwares_url(fw.id))
+
+        expect_single_resource_query("id"          => 1,
+                                     "name"        => "UEFI",
+                                     "version"     => "D7E152CUS-2.11",
+                                     "resource_id" => 1)
+      end
+    end
+
+    context "with an invalid role" do
+      it "fails to show its properties" do
+        fw = FactoryGirl.create(:firmware, :id => 1)
+
+        api_basic_authorize
+
+        run_get(firmwares_url(fw.id))
+
+        expect(response).to have_http_status(:forbidden)
+      end
+    end
+  end
+end