Added new firmware collection api #14476

rodneyhbrown7 · 2017-03-23T18:27:09Z

Adds a REST API for firmware elements
updates the product features yaml file
Adds a firmwares_controller

juliancheal · 2017-03-24T13:47:28Z

app/models/ems_refresh.rb

@@ -14,6 +14,7 @@ module EmsRefresh
  extend EmsRefresh::SaveInventoryConfiguration
  extend EmsRefresh::SaveInventoryAutomation
  extend EmsRefresh::SaveInventoryOrchestrationStacks
+  extend EmsRefresh::SaveInventoryPhysicalInfra


This line is already in master https://github.com/ManageIQ/manageiq/blob/master/app/models/ems_refresh.rb#L6

juliancheal · 2017-03-24T13:48:23Z

app/models/ems_refresh/save_inventory.rb

@@ -20,6 +20,7 @@ def save_ems_inventory(ems, hashes, target = nil)
    when ManageIQ::Providers::StorageManager                then save_ems_storage_inventory(ems, hashes, target)
    when ManageIQ::Providers::MiddlewareManager             then save_ems_middleware_inventory(ems, hashes, target)
    when ManageIQ::Providers::DatawarehouseManager          then save_ems_datawarehouse_inventory(ems, hashes, target)
+    when ManageIQ::Providers::PhysicalInfraManager          then save_ems_physical_infra_inventory(ems, hashes, target)


This line is already in master https://github.com/ManageIQ/manageiq/blob/master/app/models/ems_refresh/save_inventory.rb#L14

We have alias for EmsCloud, EmsInfra, and EmsPhysicalInfra which is why it's not written out fully and you may not have noticed it.

miq-bot · 2017-03-24T15:17:46Z

This pull request is not mergeable. Please rebase and repush.

miq-bot · 2017-03-24T20:51:46Z

This pull request is not mergeable. Please rebase and repush.

skovic · 2017-04-13T13:27:59Z

@miq-bot remove_label wip

abellotti · 2017-04-18T11:48:21Z

config/api.yml

+    :description: Firmwares
+    :options:
+    - :collection
+    - :subcollection


which primary collection is declaring this as a subcollection ?

This should be the PhysicalServer collection. The PhysicalServer collection is defined in PR #14028.

@rodneyhbrown7 it looks like in the linked PR it's not declaring this as a subcollection. It may be best to leave this out in this PR, or until you are ready to add it to the phyical server config

@abellotti @imtayadeway @rodneyhbrown7 I removed the firmwares subcollection option for now. If this PR gets merged before the linked PR (#14028), the linked PR will be updated to add this as a subcollection.

abellotti · 2017-04-18T11:51:22Z

spec/requests/api/collections_spec.rb

+
+    it 'query Firmwares' do
+      FactoryGirl.create(:firmware)
+      test_collection_query(:firmwares, "/api/firmwares", Firmware)


leverage firmwares_url() for all tests.

abellotti · 2017-04-18T11:52:36Z

spec/requests/api/firmwares_spec.rb

+        expect_single_resource_query("resource_id" => 1)
+      end
+    end
+  end


add test for invalid role and such.

abellotti · 2017-04-18T11:53:57Z

spec/requests/api/firmwares_spec.rb

+        expect_single_resource_query("id" => 1)
+        expect_single_resource_query("name" => "UEFI")
+        expect_single_resource_query("version" => "D7E152CUS-2.11")
+        expect_single_resource_query("resource_id" => 1)


these can be a single call, expect_single_resource_query("id" => 1, "name" => ...)

abellotti · 2017-04-18T11:54:36Z

/cc @imtayadeway

abellotti · 2017-04-20T17:27:02Z

Ping @imtayadeway can I borrow your 👀 for a quick review here ? Thanks !! 🎵

imtayadeway · 2017-04-20T20:12:39Z

spec/requests/api/firmwares_spec.rb

+  describe "display firmware details" do
+    context "with a valid role" do
+      it "shows its properties" do
+        fw = FactoryGirl.create(:firmware, :id => 1, :name => "UEFI",


You probably don't want to set the id here - that's the database's job and could result in some erratic behavior

imtayadeway · 2017-04-20T20:12:58Z

spec/requests/api/firmwares_spec.rb

+
+    context "with an invalid role" do
+      it "fails to show its properties" do
+        fw = FactoryGirl.create(:firmware, :id => 1)


imtayadeway · 2017-04-20T20:13:59Z

@abellotti @rodneyhbrown7 this LGTM with just a couple of nits above 👍

miq-bot · 2017-04-21T15:07:54Z

Checked commits rodneyhbrown7/manageiq@36bf074~...6266155 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 🍪

abellotti · 2017-04-24T18:19:24Z

Thanks @rodneyhbrown7 for enhancing the API.

miq-bot added the wip label Mar 23, 2017

chessbyte added api enhancement providers/physical labels Mar 23, 2017

chessbyte requested a review from juliancheal March 23, 2017 19:04

chessbyte assigned abellotti Mar 23, 2017

juliancheal reviewed Mar 24, 2017

View reviewed changes

miq-bot added the unmergeable label Mar 24, 2017

skovic force-pushed the update_firmware_api branch from d0aa13a to 2aa8384 Compare March 24, 2017 20:25

miq-bot removed the unmergeable label Mar 24, 2017

skovic force-pushed the update_firmware_api branch from 2aa8384 to 73ca1d9 Compare March 24, 2017 20:48

miq-bot added the unmergeable label Mar 24, 2017

skovic force-pushed the update_firmware_api branch from 73ca1d9 to 2531025 Compare April 11, 2017 19:35

miq-bot removed the unmergeable label Apr 11, 2017

miq-bot changed the title ~~[WIP] Update firmware api~~ Update firmware api Apr 13, 2017

miq-bot removed the wip label Apr 13, 2017

abellotti reviewed Apr 18, 2017

View reviewed changes

abellotti requested a review from imtayadeway April 18, 2017 11:54

Rodney Brown and others added 4 commits April 20, 2017 14:16

Update the firmware REST API (add controller, fix up controllers)

36bf074

Fix the firmware REST API

7f6e6b1

Add firmware controller spec tests

7036b6e

Address initial review comments

e7b1458

skovic force-pushed the update_firmware_api branch from b65d306 to e7b1458 Compare April 20, 2017 19:08

imtayadeway reviewed Apr 20, 2017

View reviewed changes

skovic added 2 commits April 21, 2017 10:39

Address additional review comments

f422f71

Remove firmwares subcollection option

6266155

abellotti added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 24, 2017

abellotti merged commit 5e00d4d into ManageIQ:master Apr 24, 2017

abellotti changed the title ~~Update firmware api~~ Added new firmwares collection api Apr 24, 2017

abellotti changed the title ~~Added new firmwares collection api~~ Added new firmware collection api Apr 24, 2017

rodneyhbrown7 deleted the update_firmware_api branch January 12, 2018 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new firmware collection api #14476

Added new firmware collection api #14476

rodneyhbrown7 commented Mar 23, 2017 •

edited

Loading

juliancheal Mar 24, 2017

juliancheal Mar 24, 2017 •

edited

Loading

miq-bot commented Mar 24, 2017

miq-bot commented Mar 24, 2017

skovic commented Apr 13, 2017

abellotti Apr 18, 2017

rodneyhbrown7 Apr 18, 2017

imtayadeway Apr 20, 2017

skovic Apr 21, 2017

abellotti Apr 18, 2017

abellotti Apr 18, 2017

abellotti Apr 18, 2017

abellotti commented Apr 18, 2017

abellotti commented Apr 20, 2017

imtayadeway Apr 20, 2017

imtayadeway Apr 20, 2017

imtayadeway commented Apr 20, 2017

miq-bot commented Apr 21, 2017

abellotti commented Apr 24, 2017

Added new firmware collection api #14476

Added new firmware collection api #14476

Conversation

rodneyhbrown7 commented Mar 23, 2017 • edited Loading

Choose a reason for hiding this comment

juliancheal Mar 24, 2017 • edited Loading

Choose a reason for hiding this comment

miq-bot commented Mar 24, 2017

miq-bot commented Mar 24, 2017

skovic commented Apr 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abellotti commented Apr 18, 2017

abellotti commented Apr 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imtayadeway commented Apr 20, 2017

miq-bot commented Apr 21, 2017

abellotti commented Apr 24, 2017

rodneyhbrown7 commented Mar 23, 2017 •

edited

Loading

juliancheal Mar 24, 2017 •

edited

Loading