Edit Authentications API #14319
Merged
Edit Authentications API #14319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot remove_label wip |
abellotti
reviewed
Mar 15, 2017
| def edit_resource(type, id, data) | ||
| auth = resource_search(id, type, collection_class(:authentications)) | ||
| task_id = auth.update_in_provider_queue(data) | ||
| action_result(true, "Updating Authentication with id #{id}", :task_id => task_id) |
There was a problem hiding this comment.
hmm, I don't think we've ever had edits return action results. I'll need to test the api client gem.
abellotti
reviewed
Mar 15, 2017
| task_id = auth.update_in_provider_queue(data) | ||
| action_result(true, "Updating Authentication with id #{id}", :task_id => task_id) | ||
| rescue => err | ||
| raise "Could not update Authentication - #{err}" |
There was a problem hiding this comment.
same idea for bulks, if edits for authentications return action result, so are the failures. Thanks.
|
This pull request is not mergeable. Please rebase and repush. |
added 3 commits
March 16, 2017 11:15
|
Checked commits jntullo/manageiq@aed46b5~...7197086 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks @jntullo for the enhancement !! 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit authentications using
update_in_provider_queue(params)Dependent on #14305
@miq-bot add_label enhancement, api, wip
@miq-bot assign @abellotti