Create/Update/Delete Ansible Tower Projects and Credentials via queue #14305
Conversation
|
Granted this is early, but don't forget the |
| task_ids = EmsRefresh.queue_refresh_task(manager) | ||
| task_ids.each { |tid| MiqTask.wait_for_taskid(tid) } | ||
|
|
||
| reload! |
There was a problem hiding this comment.
I don't think this will work. There's no class level method reload!
> ManageIQ::Providers::AnsibleTower::AutomationManager::Credential.respond_to? :reload!
=> falseYou could do something similar to the create_in_provider and return the updated inventory object.
There was a problem hiding this comment.
This is an instance method
There was a problem hiding this comment.
Do we want to make it as class method?
| queue(manager.my_zone, "create_in_provider", [manager_id, params], "Creating #{name}") | ||
| end | ||
|
|
||
| private |
There was a problem hiding this comment.
Surprisingly, this won't set the following class methods as private.
There was a problem hiding this comment.
You'll have to do private_class_method :method_name in order to get private class methods.
There was a problem hiding this comment.
it does!
I've updated my code to use send, or else it won't work
There was a problem hiding this comment.
Maybe ActiveSupport::Concern is smarter. In general adding private for class methods doesn't do anything for the class methods. It only affects the instance methods' visibility.
There was a problem hiding this comment.
Well, I'll be:
> ManageIQ::Providers::AnsibleTower::AutomationManager::Credential.private_methods.select {|m| ["queue", "refresh"].include? (m.to_s) }
=> [:refresh, :queue]
| :class_name => name, | ||
| :method_name => "create_in_provider", | ||
| :method_name => method_name, |
There was a problem hiding this comment.
This won't work for the instance methods. You'll have to pass in the id of the current instance in order to have it look up the instance to call the method.
There was a problem hiding this comment.
See here:
manageiq/app/models/miq_task.rb
Line 210 in db29ce2
There was a problem hiding this comment.
yes!!!
It was in my mind, and it slippppped...
| end | ||
|
|
||
| def update_in_provider_queue(params) | ||
| self.class.send('queue', resource.my_zone, "update_in_provider", [params], "Updating #{self.class.name}") |
There was a problem hiding this comment.
Re: https://github.com/ManageIQ/manageiq/pull/14305/files#r105751307
For instance, here, you'd have to pass in the self.id as well as update_in_provider. Otherwise, it will try to call a class method update_in_provider, which doesn't exist.
| end | ||
|
|
||
| def create_in_provider_queue(manager_id, params) | ||
| def queue(my_zone, method_name, args, action) |
There was a problem hiding this comment.
I'd call my_zone just zone to avoid confusion with the my_zone method that exists in some contexts.
jameswnl
force-pushed
the
api-UD-cred
branch
2 times, most recently
from
d9af78c to
c29d667
Compare
jameswnl
changed the title
|
@miq-bot remove_label wip |
jameswnl
changed the title
|
|
||
| def create_in_provider_queue(manager_id, params) | ||
| manager = ExtManagementSystem.find(manager_id) | ||
| queue(manager.my_zone, nil, "create_in_provider", [manager_id, params], "Creating #{name}") |
There was a problem hiding this comment.
The last argument will be logged when creating the Queue item. Can you change that to include the ems_ref for the project being created? Something like "Creating #{name} with name #{params['name']}" maybe...
There was a problem hiding this comment.
@blomquisg name or manager_ref(the native Tower ID), or id (vmdb record ID), which one is better?
There was a problem hiding this comment.
So ended up using name here because this object is not created yet. The update/delete are using manager_ref now. Done!
| end | ||
|
|
||
| def update_in_provider_queue(params) | ||
| self.class.send('queue', manager.my_zone, id, "update_in_provider", [params], "Updating #{self.class.name}") |
There was a problem hiding this comment.
Same basic comment. The "Updating ..." action should contain an ID for the thing being updated. If there's an error in updating, we'll want to know which one caused the problem.
| end | ||
|
|
||
| def delete_in_provider_queue | ||
| self.class.send('queue', manager.my_zone, id, "delete_in_provider", [], "Deleting #{self.class.name}") |
There was a problem hiding this comment.
|
|
||
| def create_in_provider_queue(manager_id, params) | ||
| manager = ExtManagementSystem.find(manager_id) | ||
| queue(manager.my_zone, nil, "create_in_provider", [manager_id, params], "Creating #{name}") |
| end | ||
|
|
||
| def update_in_provider_queue(params) | ||
| self.class.send('queue', resource.my_zone, id, "update_in_provider", [params], "Updating #{self.class.name}") |
| end | ||
|
|
||
| def delete_in_provider_queue | ||
| self.class.send('queue', resource.my_zone, id, "delete_in_provider", [], "Deleting #{self.class.name}") |
|
Checked commits jameswnl/manageiq@a9303cd~...144c8de with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
blomquisg
changed the title
@miq-bot add_labels wip, enhancement, providers/ansible_tower