-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MiqApache::Conf.create_balancer_config expects a :lbmethod key #14306
Conversation
…ethod This will allow us to pick methods other than byrequests, which was the default in MiqApache::Conf
For reference MiqApache::Conf.create_balancer_config |
Checked commit carbonin@7f537bb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
LGTM, this would fix the bybusyness of each worker not being accepted. For future me, this is the commit that broke it:
|
@jrafanie If you approve it that much why not just merge it? 🤣 |
Fine, I was caught up in the ability to approve something I already approved. 😜 |
@carbonin Should this be euwe/yes? We'd expect to use |
Sure, I labeled it no because we didn't have a specific BZ |
This will allow us to pick methods other than byrequests, which was the default in MiqApache::Conf