Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bybusiness is the only load balancing method used #147

Merged
merged 1 commit into from
May 1, 2017
Merged

bybusiness is the only load balancing method used #147

merged 1 commit into from
May 1, 2017

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Apr 27, 2017

@carbonin @jrafanie Please review

@bdunne bdunne mentioned this pull request Apr 27, 2017
Merged
@bdunne bdunne force-pushed the miq_apache_cleanup branch from 071afa7 to cce50f3 Compare April 27, 2017 17:47
@jrafanie
Copy link
Member

jrafanie commented May 1, 2017

Note, you couldn't configure the lbmethod anyways until: ManageIQ/manageiq#14306

It was broken by this commit:

commit d0aacdfa98160040958d8ddfdc98c5a56122ec56
Author: REDACTED
Date:   Wed Sep 18 11:34:10 2013 -0400

    Modify constants for two different files, pass filenames in options hash

Therefore, it's very unlikely anyone was even using this since it hasn't worked in a long time.

@jrafanie jrafanie merged commit 6406841 into ManageIQ:master May 1, 2017
@jrafanie jrafanie added this to the Sprint 60 Ending May 8, 2017 milestone May 1, 2017
@bdunne bdunne deleted the miq_apache_cleanup branch May 1, 2017 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonin carbonin carbonin approved these changes

Assignees

@jrafanie jrafanie

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdunne @jrafanie @carbonin