[WIP] Rhv 4 api support for targeted refresh

[pkliczewski]

This PR contains targeted refresh changes built on top of:

#13742

[pkliczewski]

New Provider - Inventory

[miq-bot]

Some comments on commits pkliczewski/manageiq@ba3bbc6~...050d10a

spec/models/manageiq/providers/redhat/infra_manager/event_parser_spec.rb

• ⚠️ - 71 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 73 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 74 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_4_1_spec.rb

• ⚠️ - 22 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 24 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 26 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 28 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 30 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 32 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 34 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 36 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 37 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_target_vm_4_spec.rb

• ⚠️ - 26 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 28 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 30 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 32 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 34 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 36 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 37 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commits pkliczewski/manageiq@ba3bbc6~...050d10a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
32 files checked, 120 offenses detected

app/models/manageiq/providers/redhat/infra_manager/inventory/strategies/v3.rb

• ⚠️ - Line 47, Col 7 - Lint/HandleExceptions - Do not suppress exceptions.
• ⚠️ - Line 52, Col 7 - Lint/HandleExceptions - Do not suppress exceptions.
• ⚠️ - Line 57, Col 7 - Lint/HandleExceptions - Do not suppress exceptions.
• ❗ - Line 12, Col 20 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_href.
• ❗ - Line 19, Col 9 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_href.
• ❗ - Line 34, Col 25 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_href.
• ❗ - Line 47, Col 7 - Style/RescueEnsureAlignment - rescue at 47, 6 is not aligned with end at 48, 4.
• ❗ - Line 52, Col 7 - Style/RescueEnsureAlignment - rescue at 52, 6 is not aligned with end at 53, 4.
• ❗ - Line 57, Col 7 - Style/RescueEnsureAlignment - rescue at 57, 6 is not aligned with end at 58, 4.
• ❗ - Line 61, Col 7 - Style/RedundantBegin - Redundant begin block detected.
• ❗ - Line 69, Col 7 - Style/RedundantBegin - Redundant begin block detected.
• ❗ - Line 78, Col 9 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_href.

app/models/manageiq/providers/redhat/infra_manager/inventory/strategies/v4.rb

• ⚠️ - Line 165, Col 7 - Lint/HandleExceptions - Do not suppress exceptions.
• ⚠️ - Line 170, Col 7 - Lint/HandleExceptions - Do not suppress exceptions.
• ⚠️ - Line 175, Col 7 - Lint/HandleExceptions - Do not suppress exceptions.
• ❗ - Line 165, Col 7 - Style/RescueEnsureAlignment - rescue at 165, 6 is not aligned with end at 166, 4.
• ❗ - Line 170, Col 7 - Style/RescueEnsureAlignment - rescue at 170, 6 is not aligned with end at 171, 4.
• ❗ - Line 175, Col 7 - Style/RescueEnsureAlignment - rescue at 175, 6 is not aligned with end at 176, 4.
• ❗ - Line 179, Col 7 - Style/RedundantBegin - Redundant begin block detected.
• ❗ - Line 180, Col 50 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 181, Col 13 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 181, Col 13 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
• ❗ - Line 182, Col 17 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 182, Col 17 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• ❗ - Line 183, Col 21 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 183, Col 21 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• ❗ - Line 184, Col 25 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.
• ❗ - Line 188, Col 9 - Style/IndentHash - Indent the right brace the same as the first position after the preceding left parenthesis.
• ❗ - Line 195, Col 7 - Style/RedundantBegin - Redundant begin block detected.
• ❗ - Line 197, Col 13 - Style/FirstParameterIndentation - Indent the first parameter one step more than the start of the previous line.
• ❗ - Line 197, Col 13 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 198, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 198, Col 17 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 198, Col 17 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• ❗ - Line 199, Col 21 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 199, Col 21 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• ❗ - Line 200, Col 25 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 200, Col 25 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• ❗ - Line 201, Col 29 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.
• ❗ - Line 205, Col 17 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 206, Col 21 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.
• ❗ - Line 207, Col 25 - Style/HashSyntax - Use hash rockets syntax.
• ❗ - Line 207, Col 25 - Style/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
• ❗ - Line 242, Col 7 - Style/EmptyLineBetweenDefs - Use empty lines between method definitions.
• ❗ - Line 242, Col 7 - Style/MethodMissing - When using method_missing, define respond_to_missing? and fall back on super.

app/models/manageiq/providers/redhat/infra_manager/provision/cloning.rb

• ❗ - Line 19, Col 7 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• ❗ - Line 6, Col 7 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.

app/models/manageiq/providers/redhat/infra_manager/provision/configuration.rb

• ❗ - Line 25, Col 7 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.

app/models/manageiq/providers/redhat/infra_manager/provision/configuration/container.rb

• ❗ - Line 21, Col 7 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• ❗ - Line 30, Col 7 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• ❗ - Line 37, Col 7 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.

app/models/manageiq/providers/redhat/infra_manager/refresh/parse/strategies/vm_inventory.rb

• ❗ - Line 186, Col 7 - Style/MultilineBlockChain - Avoid multi-line chains of blocks.

app/models/manageiq/providers/redhat/infra_manager/refresh/strategies/api3.rb

• ❗ - Line 22, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 30, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 31, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 5, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/models/manageiq/providers/redhat/infra_manager/event_parser_spec.rb

• ❗ - Line 100, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 101, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 102, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 103, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 104, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 105, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 109, Col 4 - Style/TrailingBlankLines - Final newline missing.
• ❗ - Line 16, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 17, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 18, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 18, Col 27 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 19, Col 27 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 1, Col 64 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 20, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 20, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 21, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 22, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 22, Col 24 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 23, Col 24 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 24, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 24, Col 22 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 25, Col 22 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 26, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 27, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 28, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 29, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 30, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 37, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 38, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 39, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 40, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 41, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 42, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 43, Col 11 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 72, Col 11 - Style/MultilineMethodCallIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• ❗ - Line 79, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 80, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 81, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 81, Col 27 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 82, Col 27 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 83, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 83, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 84, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 85, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 85, Col 24 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 86, Col 24 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 87, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 87, Col 22 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 88, Col 22 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 89, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 90, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 91, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 92, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 93, Col 16 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 99, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_4_1_spec.rb

• ❗ - Line 652, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 654, Col 13 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 670, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 674, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 675, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 676, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 677, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 678, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 679, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[pkliczewski]

This PR was only to collaborate with Boris. It is not needed any more.