[WIP] Use SDK4 for refreshing

[borod108]

this is WIP only implamented for full refresh and still a lot of refactoring to do.

[borod108]

cc @durandom would love to hear your thoughts.

[durandom]

Thats an interesting approach.
So as I understand it, you have the need to do a refresh for v3 and v4 of the ovirt API.
And the refresh part of the platform should handle that transparently.
But thats only for parsing the inventory coming from ems.rhevm_inventory

Then you have parsing strategies.
If I get it right, parse/strategies/api4.rb is the api specific parser and parse/strategies/vm_inventory.rb would be the common stuff for vm as a target - api3 and api4 agnostic.

Thats a lot of guessing - but its also quite some code :)

So, I think we are solving similar requirements with the current graph refresh. Please have a look at #13728 which has a nice description of the code layout. It will change slightly with #13907 - but the concept stays the same.
Building upon this would give you the seperation of inventory collection, parsing and persistance. Which leaves you focusing on the parsing stuff - as this is what really differs.
It'll also make refesh/refresher.rb much easier - to the point it can use the stock refresher.

Although the API version switches, that you require, are not baked into this, it would be easy to extend. You can apply your strategy pattern to the parsers in the graph refresh.

So my advice would be to collaborate on using the platform approach above - work out what shortcomings we have, that you need.

Also you might look at the ansible refresh which is a small straight forward implementation:
https://github.com/ManageIQ/manageiq/tree/9e2b41dd6d381c458eb29907b9ed9f6af9887091/app/models/manageiq/providers/ansible_tower/inventory

cc @oourfali @Ladas @pkliczewski

[miq-bot]

Some comments on commits borod108/manageiq@64a0518~...d972728

spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_4_1_spec.rb

• ⚠️ - 22 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 24 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 26 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 28 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 30 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 32 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 34 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 36 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 37 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commits borod108/manageiq@64a0518~...d972728 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
9 files checked, 11 offenses detected

app/models/manageiq/providers/redhat/infra_manager/refresh/parse/strategies/vm_inventory.rb

• ❗ - Line 186, Col 7 - Style/MultilineBlockChain - Avoid multi-line chains of blocks.

app/models/manageiq/providers/redhat/infra_manager/refresh/strategies/api4.rb

• ❗ - Line 20, Col 7 - Rails/Delegate - Use delegate to define delegations.

spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_4_1_spec.rb

• ❗ - Line 652, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 654, Col 13 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 670, Col 9 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 674, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 675, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 676, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 677, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 678, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 679, Col 17 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.