Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving requirements for updates in the development guide #3

Merged
merged 3 commits into from
Jun 20, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deleting gulp-cli
chargio committed Jun 20, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 7a2414bdb1c94c30dea0fef976812a55381924eb
1 change: 0 additions & 1 deletion scripts/playbook.yml
Original file line number Diff line number Diff line change
@@ -38,7 +38,6 @@
with_items:
- bower
- yarn
- gulp-cli
- webpack
Copy link
Member

@Fryguy Fryguy Jun 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need webpack here nor gulp-cli, but I could be wrong. @simaishi?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, packages needed are just bower and yarn as per ui build kickstart partial

Copy link
Contributor Author

@chargio chargio Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it from the developers guide, that should be corrected if we are not asking for this.

http://www.manageiq.org/docs/guides/developer_setup

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's needed for "developer setup" then?? I'm not familiar enough with the differences between our appliances vs developer setup, so I'll leave that up to someone who knows...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it is the change into 5.1, that uses yarn and webpack... I don't know about gulp, I just found it there.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@himdel himdel Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, ops UI really needs only bower and npm.

SUI however needs webpack and yarn - those are only needed to build SUI, not to use it, but since this is a dev setup, I think they are needed here.

In the short future, ops UI will also need webpack and yarn and a will stop needing bower a while after that.

gulp-cli is probably not needed at all, since SUI stopped using gulp and ops UI never used it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can delete gulp-cli, and leave the rest there. Once we move into webpack I can delete bower too.

- name: enable memcached and ensure is running
service: name=memcached state=started enabled=yes