improving requirements for updates in the development guide #3
Conversation
ManageIQ appliances nor docker containers do this, so why is this here? The project doesn't even work on 2.4 yet. |
|
@simaishi Please review |
Vagrantfile
Outdated
| echo "and do $ bin/setup to finish configuration" | ||
| echo "Server can be started with $ bundle exec rake evm:start" | ||
| echo "Server can be started with $ bin/rails evm:start" |
There was a problem hiding this comment.
I don't think we recommend bin/rails over bundle exec rake anywhere else in our guides for other platforms. You can see the same even in the guides link you have below.
There was a problem hiding this comment.
I will change it back to bundle exec then
scripts/playbook.yml
Outdated
| - bower | ||
| - yarn | ||
| - gulp-cli | ||
| - webpack |
There was a problem hiding this comment.
I don't think you need webpack here nor gulp-cli, but I could be wrong. @simaishi?
There was a problem hiding this comment.
right, packages needed are just bower and yarn as per ui build kickstart partial
There was a problem hiding this comment.
I updated it from the developers guide, that should be corrected if we are not asking for this.
There was a problem hiding this comment.
Maybe it's needed for "developer setup" then?? I'm not familiar enough with the differences between our appliances vs developer setup, so I'll leave that up to someone who knows...
There was a problem hiding this comment.
I suppose it is the change into 5.1, that uses yarn and webpack... I don't know about gulp, I just found it there.
There was a problem hiding this comment.
Right now, ops UI really needs only bower and npm.
SUI however needs webpack and yarn - those are only needed to build SUI, not to use it, but since this is a dev setup, I think they are needed here.
In the short future, ops UI will also need webpack and yarn and a will stop needing bower a while after that.
gulp-cli is probably not needed at all, since SUI stopped using gulp and ops UI never used it.
There was a problem hiding this comment.
I can delete gulp-cli, and leave the rest there. Once we move into webpack I can delete bower too.
|
@Fryguy What is the correct version of ruby? I've seen the PR merged that allows 2.4.1 to be used. Should it be 2.3.3 or 2.3.1? |
|
@sergio-ocon yeah, those changes are 2.2, 2.3, and 2.4 compatible changes to move us towards 2.4 support but we are not there yet. @jrafanie has a checklist going: ManageIQ/manageiq#14446 . That being said, many of us just use 2.4 locally anyway, and I haven't seen anything fail yet, but then again, I don't run the entire app locally either. We use Ruby 2.3.1 in the appliances, so I would go with that for maximum compatibility. https://github.com/ManageIQ/manageiq-appliance-build/blob/master/kickstarts/partials/post/ruby_install.ks.erb#L10 |
|
@Fryguy I believe that this now is ok. I will merge it when you approve it. |
This PR changes some details to reflect updates in the development guide: