[#400] Plan details playbooks support #442

michaelkro · 2018-06-26T19:51:32Z

fixes #400

Notes

~~Will squash all the WIP commits after review (reason: see 2)~~ Done
One way to test this locally is to reset --hard HEAD^^. That will undo a cleanup commit and the commit that removes the mocked data/API responses. Using the nightly db (or any db you have that has in progress plans), go to Plans in Progress and click on any plan. Things to check
- Download Log dropdowns
- Success notifications after "downloading" a playbook log (pre or post)
- Info Popovers~
Will need help verifying playbook log download implementation
Should be merged with or after Add support for pre/post-migration playbook manageiq-content#355

Screens

Running Post-migration Playbook

No Playbooks

Running Pre-migration Playbook

Playbook Log Download Success

Playbook Log Download Failure

https://bugzilla.redhat.com/show_bug.cgi?id=1564250

priley86 · 2018-07-05T16:39:00Z

app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js

-                        }}
+                      <DropdownButton
+                        id={`${task.id}-${task.descriptionPrefix}_download_log_dropdown`}
+                        title="Download Log"


__('Download Log')

priley86 · 2018-07-05T16:39:26Z

app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js

-                        {__('Download Log')}
-                      </a>
+                        {task.options.showPreMigrationOption && (
+                          <MenuItem eventKey="preMigration">Pre-migration log</MenuItem>


more 18n "Pre-migration" / "Post-migration"

priley86 · 2018-07-19T21:04:47Z

app/javascript/react/screens/App/Plan/PlanActions.js

+          dispatch({
+            type: V2V_NOTIFICATION_ADD,
+            message: successMsg,
+            notificationType: 'success',


nit... later on - we can move notificationType to a constant...

priley86 · 2018-07-19T21:05:31Z

app/javascript/react/screens/App/Plan/PlanReducer.js

+
+    if (hasPlaybookService) {
+      taskDetails.options.prePlaybookRunning =
+        task.options.playbooks.pre && task.options.playbooks.pre.job_state === 'active';


we use PLAN_JOB_STATE constants later on - not a blocker at all right now

priley86

Preliminary checks are all good here...

Would be nice to merge and get QE feedback.

AllenBW

😋 👍 mostly majorly ok with this, just a few nits and questions 🙇‍♀️ 🌄

itzah wonderful addition! 🤗

AllenBW · 2018-07-20T13:19:27Z

app/javascript/react/screens/App/Plan/PlanActions.js

+            type: DOWNLOAD_LOG_COMPLETED,
+            payload: task.id
+          });
+          dispatch({


I don't believe we need to add this notification, as this is a catch on an API.get miq notification system should take over signaling the error should any arise...

AllenBW · 2018-07-20T13:30:08Z

app/javascript/react/screens/App/Plan/PlanReducer.js

@@ -57,6 +67,20 @@ const processVMTasks = vmTasks => {
      options: {}
    };

+    const hasPlaybookService = task.options.playbooks;
+
+    if (hasPlaybookService) {


super minor nit, but we don't use hasPlaybookService anywhere but here, why not save a line, just do task.options.playbooks here?

AllenBW · 2018-07-20T13:40:26Z

app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js

+  overlayTriggerClick = task => {
+    if (task.options.playbooks) {
+      const playbookStatuses = task.options.playbooks;
+      let runningPlaybook;


another nit... any chance we can set this = null? I know I know, undefined will also be evaluated to false on line 258.... 😬 (if not 'saul good 🤗)

AllenBW · 2018-07-20T13:45:26Z

app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js

-                          e.preventDefault();
-                          downloadLogAction(task);
-                        }}
+                      <DropdownButton


Ok quick question.. I have no idea how this worked before... but If a user doesn't use a pre/post migration playbook, will they still have a log to download here? If so... maybe there should be a third option shown... to download that...

(before we had playbook support there were logs to download, just want to make sure we don't lose those)

Yup, you're totally correct. The regular Migration Log option is down here line 494

Which, apparently I didn't translate

ahh see thats what I meant! 😏 🤣

AllenBW

Yer a 👨‍🎤 @michaelkro, this is wonderful 🤗 💃

* Dropdown button for log downloads * Pre/post playbook logs will be obtained from the stdout attribute on their associated OrchestrationStack * Update task info popover to indicate when a pre/post playbook is running * Fetch running playbook template in order to display name in popover

AparnaKarve · 2018-07-24T16:50:15Z

Looks good!

Will be testing this some more on the appliance today.

Cherry picked from commit 3d3fe1d Upstream PR: ManageIQ#442 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1608420

[#400] Plan details playbooks support (cherry picked from commit 18e320d) https://bugzilla.redhat.com/show_bug.cgi?id=1608420

simaishi · 2018-07-31T01:26:37Z

Gaprindashvili backport details:

$ git log -1
commit 6d8758f2124b69374c256b42ab60187951a0966b
Author: Aparna Karve <[email protected]>
Date:   Tue Jul 24 12:35:08 2018 -0700

    Merge pull request #442 from michaelkro/playbooks-plan-details
    
    [#400] Plan details playbooks support
    (cherry picked from commit 18e320d73da6da62b5ccf316d1ca0bb666c02790)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1608420

simaishi · 2018-07-31T01:36:54Z

@michaelkro @AparnaKarve Travis is now failing in Gaprindashvili branch. I think it's caused by this PR. Can you please take a look?

/home/travis/build/ManageIQ/miq_v2v_ui_plugin/app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js
  212:3  error  renderInput should be placed after overlayTriggerClick  react/sort-comp
  238:3  error  onSelect should be placed before setPage                react/sort-comp

https://travis-ci.org/ManageIQ/miq_v2v_ui_plugin/jobs/410122179

michaelkro · 2018-07-31T01:50:27Z

@simaishi @AparnaKarve I've put up a PR against G to fix the errors #524

michaelkro added wip Sprint 10 needs-api and removed Sprint 10 labels Jun 26, 2018

michaelkro force-pushed the playbooks-plan-details branch 14 times, most recently from 61848e7 to 8135419 Compare July 2, 2018 16:11

priley86 reviewed Jul 5, 2018

View reviewed changes

michaelkro force-pushed the playbooks-plan-details branch 7 times, most recently from 517c077 to def1e45 Compare July 11, 2018 14:41

priley86 added the gaprindashvili/yes label Jul 11, 2018

michaelkro force-pushed the playbooks-plan-details branch from 7676f71 to bca7de1 Compare July 12, 2018 17:38

michaelkro removed the waiting-on-another-issue label Jul 19, 2018

priley86 reviewed Jul 19, 2018

View reviewed changes

priley86 approved these changes Jul 19, 2018

View reviewed changes

michaelkro force-pushed the playbooks-plan-details branch from f91dac0 to 2fe745f Compare July 20, 2018 11:19

AllenBW reviewed Jul 20, 2018

View reviewed changes

michaelkro force-pushed the playbooks-plan-details branch from 35faee6 to 039b918 Compare July 20, 2018 14:29

priley86 mentioned this pull request Jul 20, 2018

[Abandoned][#370] Cancel Migration Plan / Cancel Mike's Plans #509

Closed

AllenBW added the enhancement label Jul 20, 2018

AllenBW approved these changes Jul 20, 2018

View reviewed changes

priley86 mentioned this pull request Jul 20, 2018

[WIP][#370] Cancel a migration's tasks #511

Closed

michaelkro force-pushed the playbooks-plan-details branch from 039b918 to 3d3fe1d Compare July 20, 2018 20:16

AparnaKarve mentioned this pull request Jul 24, 2018

[#399] Pre/Post Playbook Overview UI + API #491

Merged

AparnaKarve approved these changes Jul 24, 2018

View reviewed changes

AparnaKarve merged commit 18e320d into ManageIQ:master Jul 24, 2018

AparnaKarve added the blocker label Jul 26, 2018

michaelkro added a commit to michaelkro/manageiq-v2v that referenced this pull request Jul 30, 2018

Playbook support in plan details page

202c980

Cherry picked from commit 3d3fe1d Upstream PR: ManageIQ#442 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1608420

michaelkro mentioned this pull request Jul 30, 2018

[GAPRINDASHVILI] Playbook support in plan details page #523

Closed

michaelkro added a commit to michaelkro/manageiq-v2v that referenced this pull request Jul 31, 2018

[GAPRINDASHVILI] Playbook support in plan details page

43d5e06

Cherry picked from commit 3d3fe1d Upstream PR: ManageIQ#442 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1608420

simaishi pushed a commit that referenced this pull request Jul 31, 2018

Merge pull request #442 from michaelkro/playbooks-plan-details

6d8758f

[#400] Plan details playbooks support (cherry picked from commit 18e320d) https://bugzilla.redhat.com/show_bug.cgi?id=1608420

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Jul 31, 2018

michaelkro mentioned this pull request Jul 31, 2018

[GAPRINDASHVILI] Rearrange methods according to eslint rules #524

Merged

michaelkro deleted the playbooks-plan-details branch August 2, 2018 12:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#400] Plan details playbooks support #442

[#400] Plan details playbooks support #442

michaelkro commented Jun 26, 2018 •

edited by AparnaKarve

Loading

priley86 Jul 5, 2018

priley86 Jul 5, 2018

priley86 Jul 19, 2018

priley86 Jul 19, 2018

priley86 left a comment

AllenBW left a comment

AllenBW Jul 20, 2018

AllenBW Jul 20, 2018

AllenBW Jul 20, 2018

AllenBW Jul 20, 2018

michaelkro Jul 20, 2018

michaelkro Jul 20, 2018

AllenBW Jul 20, 2018

AllenBW left a comment

AparnaKarve commented Jul 24, 2018

simaishi commented Jul 31, 2018

simaishi commented Jul 31, 2018

michaelkro commented Jul 31, 2018 •

edited

Loading

[#400] Plan details playbooks support #442

[#400] Plan details playbooks support #442

Conversation

michaelkro commented Jun 26, 2018 • edited by AparnaKarve Loading

Notes

Screens

Running Post-migration Playbook

No Playbooks

Running Pre-migration Playbook

Playbook Log Download Success

Playbook Log Download Failure

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

priley86 left a comment

Choose a reason for hiding this comment

AllenBW left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AllenBW left a comment

Choose a reason for hiding this comment

AparnaKarve commented Jul 24, 2018

simaishi commented Jul 31, 2018

simaishi commented Jul 31, 2018

michaelkro commented Jul 31, 2018 • edited Loading

michaelkro commented Jun 26, 2018 •

edited by AparnaKarve

Loading

michaelkro commented Jul 31, 2018 •

edited

Loading