Code cleanup

ManageIQ · Jul 20, 2018 · 35faee6 · 35faee6
1 parent 2fe745f
commit 35faee6
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/app/javascript/react/screens/App/Plan/PlanActions.js b/app/javascript/react/screens/App/Plan/PlanActions.js
@@ -53,13 +53,6 @@ const _getOrchestrationStackActionCreator = (url, playbookScheduleType, task) =>
             type: DOWNLOAD_LOG_COMPLETED,
             payload: task.id
           });
-          dispatch({
-            type: V2V_NOTIFICATION_ADD,
-            message: e.error.message,
-            notificationType: 'error',
-            persistent: true,
-            actionEnabled: false
-          });
           reject(e);
         })
     )

diff --git a/app/javascript/react/screens/App/Plan/PlanReducer.js b/app/javascript/react/screens/App/Plan/PlanReducer.js
@@ -67,9 +67,7 @@ const processVMTasks = vmTasks => {
       options: {}
     };
 
-    const hasPlaybookService = task.options.playbooks;
-
-    if (hasPlaybookService) {
+    if (task.options.playbooks) {
       taskDetails.options.prePlaybookRunning =
         task.options.playbooks.pre && task.options.playbooks.pre.job_state === 'active';
       taskDetails.options.postPlaybookRunning =

diff --git a/...vascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js b/...vascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js
@@ -247,7 +247,7 @@ class PlanRequestDetailList extends React.Component {
   overlayTriggerClick = task => {
     if (task.options.playbooks) {
       const playbookStatuses = task.options.playbooks;
-      let runningPlaybook;
+      let runningPlaybook = null;
 
       for (const scheduleType in playbookStatuses) {
         if (playbookStatuses[scheduleType].job_state === 'active') {