Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ViewHelper instead of <tags> in policy simulation results tree #77

Merged
merged 1 commit into from
Jan 6, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Jan 5, 2017

This makes the .html_safe calls obsolete and also escapes any harmful JS retrieved from the database.

@miq-bot miq-bot added the wip label Jan 5, 2017
@skateman skateman changed the title [WIP] Use ViewHelper instead of <tags> in policy simulation results tree Use ViewHelper instead of <tags> in policy simulation results tree Jan 5, 2017
@miq-bot miq-bot removed the wip label Jan 6, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 6, 2017

Checked commit skateman@ee5600a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 👍

@martinpovolny martinpovolny added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 6, 2017
@martinpovolny martinpovolny self-assigned this Jan 6, 2017
@martinpovolny martinpovolny merged commit a7f153e into ManageIQ:master Jan 6, 2017
@skateman skateman deleted the html-safe branch January 6, 2017 10:40
@skateman
Copy link
Member Author

skateman commented Jan 6, 2017

Created a separate backport PR for euwe as this one was depending on a post-euwe feature.

@simaishi
Copy link
Contributor

@skateman Please create a BZ if it doesn't already exist.

@simaishi
Copy link
Contributor

@simaishi
Copy link
Contributor

Backported to Euwe via ManageIQ/manageiq#13372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants