Use ViewHelper instead of <tags> in policy simulation results tree

This makes the .html_safe obsolete and also escapes any harmful JS
retrieved from the database.

app/presenters/tree_builder_policy_simulation_results.rb

@@ -36,10 +36,18 @@ def node_icon(result)
     end
   end
 
+  def prefixed_title(prefix, title)
+    ViewHelper.capture do
+      ViewHelper.concat ViewHelper.content_tag(:strong, "#{prefix}:")
+      ViewHelper.concat ' '
+      ViewHelper.concat title
+    end
+  end
+
   def vm_nodes(data)
     data.sort_by! { |a| a[:name].downcase }.map do |node|
       {:id          => node[:id],
-       :text        => "<strong>VM:</strong> #{node[:name]}".html_safe,
+       :text        => prefixed_title(_('VM'), node[:name]),
        :image       => '100/vm.png',
        :profiles    => node[:profiles],
        :cfmeNoClick => true}
@@ -49,7 +57,7 @@ def vm_nodes(data)
   def profile_nodes(data)
     data.sort_by! { |a| a[:description].downcase }.map do |node|
       {:id          => node[:id],
-       :text        => "<strong>#{_('Profile:')}</strong> #{node[:description]}".html_safe,
+       :text        => prefixed_title(_('Profile'), node[:description]),
        :image       => node_icon(node[:result]),
        :policies    => node[:policies],
        :cfmeNoClick => true}
@@ -60,7 +68,7 @@ def policy_nodes(data)
     data.sort_by! { |a| a[:description].downcase }.map do |node|
       active_caption = node[:active] ? "" : _(" (Inactive)")
       {:id          => node['id'],
-       :text        => "<strong>#{_('Policy')}#{active_caption}:</strong> #{node[:description]}".html_safe,
+       :text        => prefixed_title("#{_('Policy')}#{active_caption}", node[:description]),
        :image       => node_icon(node[:result]),
        :conditions  => node[:conditions],
        :actions     => node[:actions],
@@ -72,7 +80,7 @@ def policy_nodes(data)
   def action_nodes(data)
     data.map do |node|
       {:id          => node[:id],
-       :text        => "<strong>#{_('Action:')}</strong> #{node[:description]}".html_safe,
+       :text        => prefixed_title(_('Action'), node[:description]),
        :image       => node_icon(node[:result]),
        :cfmeNoClick => true}
     end
@@ -81,7 +89,7 @@ def action_nodes(data)
   def condition_nodes(data)
     data.map do |node|
       {:id          => node[:id],
-       :text        => "<strong>#{_('Condition:')}</strong> #{node[:description]}".html_safe,
+       :text        => prefixed_title(_('Condition'), node[:description]),
        :image       => node_icon(node[:result]),
        :expression  => node[:expression],
        :cfmeNoClick => true}
@@ -91,7 +99,7 @@ def condition_nodes(data)
   def scope_node(data)
     name, tip = exp_build_string(data)
     {:id          => nil,
-     :text        => "<strong>#{_('Scope:')}</strong> <span class='ws-wrap'>#{name}".html_safe,
+     :text        => prefixed_title(_('Scope'), name),
      :tip         => tip.html_safe,
      :image       => node_icon(data[:result]),
      :cfmeNoClick => true}
@@ -108,7 +116,7 @@ def expression_node(data)
               '100/na.png'
             end
     {:id          => nil,
-     :text        => "<strong>#{_('Expression:')}</strong> <span class='ws-wrap'>#{name}".html_safe,
+     :text        => prefixed_title(_('Expression'), name),
      :tip         => tip.html_safe,
      :image       => image,
      :cfmeNoClick => true}