Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container project dashboard - add missing dataAvailable #7185

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Container project dashboard - add missing dataAvailable #7185

merged 2 commits into from
Jul 8, 2020

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Jul 7, 2020

Fixes #7186

Compute > Containers > Projects
pick a project, switch to dashboard view

Add dataAvailable to a couple of places in dashboard services.
Otherwise, the container project dashboard doesn't display anything,
because loadingDone is true (no spinner),
dataAvailable is not false (no empty message),
or true (no chart).

I suspect the dataAvailable logic somehow changed in the other dashboards and this one was never updated, but I don't see the commit.

@h-kataria any ideas? Or, does this make sense as is?


Before:

before

After:

after


Testing: you can use https://github.com/yaacov/miq-scripts/blob/master/set-miq-metric.rb to generate data, as long as you have at least one container project.

otherwise, the dashboard doesn't display anything,
because loadingDone is true (no spinner),
dataAvailable is not false (no empty message),
or true (no chart)
@chessbyte
Copy link
Member

@himdel test failures are related

@h-kataria
Copy link
Contributor

@himdel verified fix in UI, looked into code a bit, don't see how this could have worked and did not find any recent changes that could have introduced the issue.
LGTM, after travis failures are fixed.

@h-kataria
Copy link
Contributor

@himdel I did not look at haml view files, was focussing on JS and dashboard services code. Looks like changes in #7033 surfaced this issue. But still your changes are valid and good.

@himdel
Copy link
Contributor Author

himdel commented Jul 8, 2020

Looks like changes in #7033 surfaced this issue.

Aah, I see it now, thanks! :) Adding ivanchuk/yes to match.

@himdel
Copy link
Contributor Author

himdel commented Jul 8, 2020

test failures are related

Fixed :)

@miq-bot
Copy link
Member

miq-bot commented Jul 8, 2020

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/dc1cd5fb654ae69365ba2b66f2d25ff076b291ed~...030d7c17a3d150b8ebac4d0dc61b0f4f9fafa03f with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
3 files checked, 0 offenses detected
Everything looks fine. 👍

@himdel himdel closed this Jul 8, 2020
@himdel himdel reopened this Jul 8, 2020
@himdel
Copy link
Contributor Author

himdel commented Jul 8, 2020

spec:javascript failure unrelated, also happens locally on master (though not on travis apparently)

(looks related to dependencies, it works with yesterday's yarn.lock, looking)

EDIT: And it's gone gone gone... something like a version mismatch causing webpack or babel to use incompatible exports/import types, webpack code worked but non-webpack code didn't see it, I think.
Making sure.

@himdel himdel closed this Jul 8, 2020
@himdel himdel reopened this Jul 8, 2020
@h-kataria h-kataria merged commit b21c7d9 into ManageIQ:master Jul 8, 2020
@himdel himdel deleted the container-project-dashboard branch July 8, 2020 13:47
simaishi pushed a commit that referenced this pull request Jul 8, 2020
Container project dashboard - add missing dataAvailable

(cherry picked from commit b21c7d9)
@simaishi
Copy link
Contributor

simaishi commented Jul 8, 2020

Jansa backport details:

$ git log -1
commit 55836c1bed7220d66cca361207ce83a1b0d91123
Author: Harpreet Kataria <[email protected]>
Date:   Wed Jul 8 09:28:47 2020 -0400

    Merge pull request #7185 from himdel/container-project-dashboard

    Container project dashboard - add missing dataAvailable

    (cherry picked from commit b21c7d9f86e18927a33e7484077e6e8bb5805158)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilization/Trends are shown on the container provider level but not on the projects level
6 participants