-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container project dashboard - add missing dataAvailable #7185
Conversation
otherwise, the dashboard doesn't display anything, because loadingDone is true (no spinner), dataAvailable is not false (no empty message), or true (no chart)
@himdel test failures are related |
@himdel verified fix in UI, looked into code a bit, don't see how this could have worked and did not find any recent changes that could have introduced the issue. |
Aah, I see it now, thanks! :) Adding ivanchuk/yes to match. |
Fixed :) |
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/dc1cd5fb654ae69365ba2b66f2d25ff076b291ed~...030d7c17a3d150b8ebac4d0dc61b0f4f9fafa03f with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
(looks related to dependencies, it works with yesterday's yarn.lock, looking) EDIT: And it's gone gone gone... something like a version mismatch causing webpack or babel to use incompatible exports/import types, webpack code worked but non-webpack code didn't see it, I think. |
Container project dashboard - add missing dataAvailable (cherry picked from commit b21c7d9)
Jansa backport details:
|
Fixes #7186
Compute > Containers > Projects
pick a project, switch to dashboard view
Add
dataAvailable
to a couple of places in dashboard services.Otherwise, the container project dashboard doesn't display anything,
because
loadingDone
is true (no spinner),dataAvailable
is not false (no empty message),or true (no chart).
I suspect the
dataAvailable
logic somehow changed in the other dashboards and this one was never updated, but I don't see the commit.@h-kataria any ideas? Or, does this make sense as is?
Before:
After:
Testing: you can use https://github.com/yaacov/miq-scripts/blob/master/set-miq-metric.rb to generate data, as long as you have at least one container project.