Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old container provider forms with the new DDF version #7155

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

skateman
Copy link
Member

@skateman skateman commented Jun 29, 2020

Instead of selecting the protocols for metrics, alerts and virtualization in the common area, I moved these dropdowns into the corresponding tabs which are always visible. This way the protocol selection is consistent with other provider screens. The detect button is already in the schema, but as there's no API endpoint for the feature, it is hidden and its behavior is not yer implemented. The kubevirt tab has all the fields editable and the user has to manually copy its values as the DDF can't do it automatically. Eventually, there will be a detect button that would copy the values on-demand.

Before:
Screenshot from 2020-08-06 12-57-46
Screenshot from 2020-08-06 12-57-58

After:
Screenshot from 2020-08-06 12-54-32
Screenshot from 2020-08-06 12-55-05

Parent issue: ManageIQ/manageiq#18818
Depends on: ManageIQ/manageiq-providers-kubernetes#385

@skateman skateman force-pushed the container-provider-forms branch from df5405c to 894a747 Compare August 6, 2020 10:48
@miq-bot
Copy link
Member

miq-bot commented Aug 6, 2020

Checked commit skateman@894a747 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby25, which recognizes
warning: 2.5.8-compliant syntax, but you are running 2.5.7.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works for me

@skateman skateman changed the title [WIP] Replace old container provider forms with the new DDF version Replace old container provider forms with the new DDF version Aug 7, 2020
@skateman
Copy link
Member Author

skateman commented Aug 7, 2020

I guess we can get this in, we will implement the Detect button after the API endpoint is ready.

@miq-bot miq-bot removed the wip label Aug 7, 2020
@h-kataria
Copy link
Contributor

verified in UI, looks good.

@h-kataria h-kataria merged commit f725e29 into ManageIQ:master Aug 8, 2020
@skateman skateman deleted the container-provider-forms branch August 8, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants